docs: add contributor security checklist for vault contract changes - #568
Merged
El-swaggerito merged 1 commit intoJul 29, 2026
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #418
Contributor security checklist added
The repository now includes a practical security review checklist for vault contract changes in security-checklist.md, and it is linked from the main documentation index in README.md.
What it covers
Accounting and lock-state invariants
Token transfer atomicity and rollback safety
Authorisation and privilege boundaries
Storage migration and event compatibility
Error-code handling and required test coverage
Verification
I confirmed the checklist file exists and that the new README entry points contributors to it.