test: add unit tests for vault interaction methods with mocked StellarSDK dependencies#202
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soroban Vault Boundary Tests
Closes #188
Summary
This PR introduces comprehensive boundary tests for the Soroban Savings Vault module (
src/soroban/index.ts). These tests validate that the SDK interacts correctly with the deployed smart contract, handles inputs/outputs precisely, and wraps any simulated or network errors robustly.Motivation
To ensure the reliability of the PocketPay SDK when interacting with the Soroban smart contracts, we need to guarantee that the
depositToVault,withdrawFromVault, andgetVaultBalancefunctions work seamlessly under various network constraints and handle boundaries appropriately.What's New
New Test Suite (
tests/vault.test.ts)A dedicated unit testing suite was created for the Soroban methods, utilizing robust
vi.mocktechniques to simulate Horizon/Soroban RPC behavior without any live network dependencies. The mocked operations explicitly document the expected real-network state transformations.depositToVaultdeposit), invalid secret validation, success mappings, simulation errors, unhandled RPC wrapper handling.withdrawFromVaultwithdraw), amount validation, success mappings, and transaction submission error handling.getVaultBalanceget_balance), public key validation, timeout/offline wrapping, and parsingscValToNativeback to an XLM string.Files Changed
tests/vault.test.tssrc/soroban/index.tsAcceptance Criteria
Verification