Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch Auction Bid & Settlement #20

Merged
merged 124 commits into from
Jan 31, 2024
Merged

Batch Auction Bid & Settlement #20

merged 124 commits into from
Jan 31, 2024

Conversation

Oighty
Copy link
Contributor

@Oighty Oighty commented Jan 11, 2024 •
edited by 0xJem
Loading

0xJem
0xJem reviewed Jan 18, 2024
View reviewed changes
src/AuctionHouse.sol Outdated Show resolved Hide resolved
0xJem
0xJem reviewed Jan 18, 2024
View reviewed changes
src/AuctionHouse.sol Outdated Show resolved Hide resolved
0xJem
0xJem reviewed Jan 18, 2024
View reviewed changes
src/AuctionHouse.sol Outdated Show resolved Hide resolved
0xJem
0xJem reviewed Jan 18, 2024
View reviewed changes
src/modules/auctions/EBA.SOL Outdated Show resolved Hide resolved
0xJem
0xJem reviewed Jan 18, 2024
View reviewed changes
src/AuctionHouse.sol Outdated Show resolved Hide resolved
@0xJem 0xJem mentioned this pull request Jan 18, 2024
Merged
0xJem and others added 18 commits January 18, 2024 16:17
@0xJem
Rename internal function
6d388ad
@0xJem
Comment improvements
82b2ef5
@0xJem
Extract shared functions. Partial implementation of AuctionHouse.bid()
3605cde
@0xJem
Reconcile signatures for bid functions
9ea9196
@0xJem
Add settle function for local storage, external settlement
7bc9988
@0xJem
Shift to _isAllowed() function
be3c092
@0xJem
Shift fee implementation
b9f3479
@0xJem
Adjust bid/settle signatures. Remove unused functions.
824eb90
@Oighty
wip: initial LSBBA implementation (not complete)
c7b701c
@Oighty
feat: LSBBA updates
0506ec1
@Oighty
feat: add priority queue implementation to LSSBA
4b97dcb
@Oighty
feat: add settlement function to LSBBA
eb9c1ae
@Oighty
feat: add auction, cancelAuction, and claimRefund functions to LSBBA
55acd28
@0xJem
Notes
5fb4ca4
@0xJem
Merge branch 'jem/batch-auctions' of github.com:Bond-Protocol/moonrak…
c7c6911 
…er into jem/batch-auctions
@0xJem
chore: linting
89e47c2
@0xJem
Complete migration of lotId to uint96. Fix compilation errors.
8ff6fc7
@0xJem
Fix stack too deep error
114334a
Oighty
Oighty commented Jan 29, 2024
View reviewed changes
Copy link
Contributor Author

@Oighty Oighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settle looks pretty good. I made a comment about changing the partial fill refund slightly.

src/AuctionHouse.sol Outdated Show resolved Hide resolved
src/AuctionHouse.sol Show resolved Hide resolved
@0xJem 0xJem self-assigned this Jan 31, 2024
This was linked to issues Jan 31, 2024
Auction House: Auction Creation and Management #5
Closed
Auction House: Bids and Settlement for Batch Auctions #7
Closed
Auction Module Base Contracts #12
Closed
Marginal Price Sealed Bid Batch Auction - Local Submission, Local Evaluation #25
Closed
@0xJem
Copy link
Contributor

0xJem commented Jan 31, 2024

@Oighty feel free to merge if you're good with the capacityInQuote protections

@Oighty
Copy link
Contributor Author

Oighty commented Jan 31, 2024

@Oighty feel free to merge if you're good with the capacityInQuote protections

I made a small refactor, but yes going to merge.

@Oighty Oighty merged commit 5bf9fa8 into master Jan 31, 2024
1 check passed
@Oighty Oighty deleted the batch-auctions branch January 31, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJem 0xJem 0xJem left review comments

Assignees

@0xJem 0xJem

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Oighty @0xJem