Repository navigation
Conversation
open() only recognized a null position as "start from the beginning" and had no handling for LATEST at all, so both TrackingToken.FIRST and LATEST threw an IllegalArgumentException instead of resolving like every other StreamableEventSource. AxonFramework's StartingFrom now normalizes null to FIRST, so the null branch here would have gone dead without this change. Resolve FIRST and LATEST the same way as the existing null case, via each source's firstToken()/latestToken(). No backward-compatible null handling kept, since AF and Axoniq ship as a single coordinated release.
|
❌ The last analysis has failed. |
hjohn
marked this pull request as ready for review
September 28, 2026 11:56
hjohn
requested review from
MateuszNaKodach,
jangalinski and
zambrovski
and removed request for
a team
September 28, 2026 11:56
Contributor
Build status (run 36418446130, commit 0a1a493)JDK 21 - FAILURE - 17 succeeded, 1 failed, 13 skipped (0 cached, 18 built) in 12:08Per-module details
JDK 25 - FAILURE - 17 succeeded, 1 failed, 13 skipped (0 cached, 18 built) in 12:50Per-module details
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
Author
|
This build will fail until the AF change is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to AxonIQ/AxonFramework#5086. MultiStreamableEventSource.open() only handled a null position as "start from the beginning" and never handled TrackingToken.LATEST at all, so both FIRST and LATEST threw IllegalArgumentException instead of resolving. AxonFramework's StartingFrom now normalizes null to FIRST, so the null branch here would go dead without this change.
startingFrom(null)tostartingFrom(TrackingToken.FIRST).Depends on the AxonFramework 5.4.0-SNAPSHOT build including AxonIQ/AxonFramework#5086 (also fixes AsyncInMemoryStreamableEventSource.latestToken() returning null on an empty store, which the new LATEST test here exposed).