Repository navigation
Conversation
Introduce PersistentStreamExecutorRegistry. The registry provides us a means to collectively close all the ScheduledExecutorServices for PersistentStreams as part of Axon Framework's shutdown flow #230
Configure a PersistentStreamExecutorRegistry when not present. The shutdownAll is registered as a shutdown handler for the ComponentDefinition #230
Use registry to track executor. The shutdownAll is registered as a shutdown handler for the ComponentDefinition #230
Move Spring dependencies out of enhancer. This allows us to move the enhancer to the persistent packaging, so it can be reused #230
Move enhancer and registry to axon-server-connector. None of their features are Spring specific, so they don't belong there anymore #230
Add unit tests for PersistentStreamConfigurationEnhancer #230
Contributor
Build status (run 44086388672, commit 85c2d60)JDK 21 - SUCCESS - 33 modules (23 cached, 10 built) in 14:56Per-module details
JDK 25 - UNKNOWN - no per-module data found; the build likely did not complete (e.g. timed out or was cancelled) -- check the build step's own logPer-module details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the
PersistentStreamConfigurationEnhancerslightly so.It does roughly the following to achieve this:
PersistentStreamExecutorRegistryto contain all theScheduledExecutorServiceinstances of Persistent Stream sources. This provides a single place to shut down all executors on app shut down.PersistentStreamConfigurationEnhancer, by dropping theDisposableBeanandObjectProviderdependencies. The former is possible due to the introduction of thePersistentStreamExecutorRegistry. The latter was easily replaced by aSupplier.PersistentStreamConfigurationEnhancerand newPersistentStreamExecutorRegistryto theaxon-server-connectormodule. None of this is Spring specific after all. The move makes it feasible to reuse thePersistentStreamConfigurationEnhancerfor future other dependency injection framework integrations.By doing the above, this PR resolves #230.