Skip to content

added brightness lib #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brainlessbitch
Copy link

simple brightness lib, idk, this is needed imo

@kotontrion
Copy link
Collaborator

here are my 2 cents:
make the backlight_model property construct only
add a BrightnessManager class, which creates creates an instance of the Brightness class for each available device.
Also leds follow the same directory structure (at /sys/class/leds/), so with this approach we can also support things like numlock, capslock, keyboard backlight, etc. See #336

Then to make usage easier, the brightness manager might also have a brightness property, which either acts as a proxy for just one display backlight, or maybe better set the brightness for all display backlights, similar to the volume prop in the AstalWp nodes with multiple channels.

@ItsLiyua
Copy link

I'd be interested in something like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants