Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fallbacktointernet for dns zone #962

Merged
merged 9 commits into from
Mar 6, 2025

Conversation

jantorep
Copy link
Contributor

@jantorep jantorep commented Feb 20, 2025

Overview/Summary

Added
@sys.description('Fallback to internet for Azure Private DNS zones.')
param parResolutionPolicy string = 'NxDomainRedirect' on line 17-18
resolutionPolicy: parResolutionPolicy on line 41

This added the Fallback to internet for Azure Private DNS zones parameter to the Virtual Network Link for the Private DNS

Related Issues/Work Items

Closes #961

This PR fixes/adds/changes/removes

Issue is that with Private DNS Zones for PaaS services enabled as of now services that does not have a Private Endpoint does not resolve the Public ### Breaking Changes

Testing Evidence

Tested in our environment and it applies the setting

-)

@jantorep jantorep requested a deployment to BicepUpdateDocumentation February 20, 2025 10:20 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation February 28, 2025 06:50 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation February 28, 2025 06:51 — with GitHub Actions Waiting
@oZakari oZakari requested a deployment to BicepUpdateDocumentation February 28, 2025 06:51 — with GitHub Actions Waiting
@oZakari oZakari changed the title add fallbacktointernet for dns zone feat: add fallbacktointernet for dns zone Feb 28, 2025
@oZakari oZakari added the Area: Networking 🌐 Issues / PR's related to Networking label Feb 28, 2025
@oZakari oZakari requested a deployment to BicepUpdateDocumentation February 28, 2025 06:52 — with GitHub Actions Waiting
@oZakari oZakari added the Needs: Author Feedback 👂 Needs the author to provide feedback label Feb 28, 2025
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jantorep, thanks again for the PR. Can you take a look at my suggestion as well the parameters.json file with the new param you created? You can then update the table in the markdown file with the new param. The rest of the value gets generated through our PR workflow so no need to worry about those. Let me know if you have any questions.

…Links.bicep


I would suggest have the NxDomainRedirect as default in the code. As most does not know about this setting. And based on my experience it's been a big problem where you use private and public Azure services.

Co-authored-by: Zach Trocinski <[email protected]>
@jantorep jantorep requested a deployment to BicepUpdateDocumentation February 28, 2025 08:24 — with GitHub Actions Waiting
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 Needs the author to provide feedback label Feb 28, 2025
@jantorep jantorep requested a review from oZakari February 28, 2025 08:25
@jantorep
Copy link
Contributor Author

I commented in the change request, could we have the default setting to NxDomainRedirect as most wont know about this setting and most will need to use both private and public SaaS services. Both with resources in same tenant and other external tenants.

I will also create a pull request to the Markdown file. I noticed the vwan bicep file now points to a AVM module. Will the change i requested here get polulated to the AVM module? Or do i need to request a change there as well?

@jantorep jantorep requested a deployment to BicepUpdateDocumentation February 28, 2025 10:24 — with GitHub Actions Waiting
@oZakari
Copy link
Contributor

oZakari commented Mar 6, 2025

I commented in the change request, could we have the default setting to NxDomainRedirect as most wont know about this setting and most will need to use both private and public SaaS services. Both with resources in same tenant and other external tenants.

I will also create a pull request to the Markdown file. I noticed the vwan bicep file now points to a AVM module. Will the change i requested here get polulated to the AVM module? Or do i need to request a change there as well?

Hi @jantorep, I am just going to leave the default value as true for now to avoid any breaking changes, and try to keep the default configurations consistent across all our ALZ IaC frameworks.

The private dns link module is not used at all in the VWAN modules, just the private dns zone creation. Will create the parameter file in your pr to include your new param and then will merge. Thanks again!

@oZakari oZakari requested a deployment to BicepUpdateDocumentation March 6, 2025 18:17 — with GitHub Actions Waiting
@oZakari oZakari temporarily deployed to BicepUpdateDocumentation March 6, 2025 18:19 — with GitHub Actions Inactive
oZakari
oZakari previously approved these changes Mar 6, 2025
Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oZakari oZakari deployed to BicepUpdateDocumentation March 6, 2025 18:27 — with GitHub Actions Active
@oZakari oZakari merged commit 0719ef6 into Azure:main Mar 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Networking 🌐 Issues / PR's related to Networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Private DNS Zone] - Add Fall back to Internet as default behavior for Azure PaaS Private DNS Zones
2 participants