add e2e to verify node can be bootstrapped

Azure · Feb 17, 2025 · ac6356f · ac6356f
1 parent 27ca7dc
commit ac6356f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/e2e/scenario_test.go b/e2e/scenario_test.go
@@ -1664,3 +1664,22 @@ func Test_Ubuntu2404ARM(t *testing.T) {
 		},
 	})
 }
+
+func Test_Ubuntu2204_MetricsFromCRI(t *testing.T) {
+	RunScenario(t, &Scenario{
+		Description: "tests that a node on ubuntu 2204 bootstrapped with metrics from CRI enabled will still have kubelet metrics",
+		Config: Config{
+			Cluster: ClusterKubenet,
+			VHD:     config.VHDUbuntu2204Gen2Containerd,
+			BootstrapConfigMutator: func(nbc *datamodel.NodeBootstrappingConfiguration) {
+				if nbc.KubeletConfig == nil {
+					nbc.KubeletConfig = map[string]string{}
+				}
+				nbc.KubeletConfig["--pod-container-stats-cri"] = "true"
+			},
+			Validator: func(ctx context.Context, s *Scenario) {
+				ValidateFileHasContent(ctx, s, "/etc/default/kubelet", "--feature-gates=PodAndContainerStatsFromCRI=true")
+			},
+		},
+	})
+}
diff --git a/pkg/agent/utils.go b/pkg/agent/utils.go
@@ -45,6 +45,7 @@ var TranslatedKubeletConfigFlags = map[string]bool{
 	"--eviction-hard":                     true,
 	"--node-status-update-frequency":      true,
 	"--node-status-report-frequency":      true,
+	"--pod-container-stats-cri":           true,
 	"--image-gc-high-threshold":           true,
 	"--image-gc-low-threshold":            true,
 	"--event-qps":                         true,