-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: containerd config registry host file to cse #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a460d1
to
f22e6c1
Compare
f22e6c1
to
d63bad7
Compare
d63bad7
to
52d4054
Compare
52d4054
to
d6d0782
Compare
d6d0782
to
fd0450b
Compare
fseldow
approved these changes
Dec 16, 2024
karataliu
reviewed
Dec 17, 2024
fd0450b
to
c232872
Compare
@cameronmeissner Could you please have another round of review? The E2E failed due to quota issue. Should we skip it?
|
karataliu
approved these changes
Dec 18, 2024
c232872
to
b898ee1
Compare
we can skip this if the relevant scenarios have passed - please make sure to run once more before merging at least |
cameronmeissner
approved these changes
Jan 6, 2025
b898ee1
to
fe2c731
Compare
fe2c731
to
0a5a489
Compare
0a5a489
to
6a8791f
Compare
djsly
approved these changes
Jan 21, 2025
lilypan26
approved these changes
Jan 22, 2025
7f311c8
to
4c81577
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Move the containerd config registry host file from custom data to the CSE provisioning scripts to make the scriptless/self-contained effort.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: