Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: containerd config registry host file to cse #5393

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

bingosummer
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Move the containerd config registry host file from custom data to the CSE provisioning scripts to make the scriptless/self-contained effort.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@bingosummer
Copy link
Member Author

@cameronmeissner Could you please have another round of review?

The E2E failed due to quota issue. Should we skip it?

=== NAME  Test_Ubuntu2204_GPUA100
    vmss.go:75: 
        	Error Trace:	/mnt/vss/_work/1/s/e2e/vmss.go:75
        	            				/mnt/vss/_work/1/s/e2e/scenario_helpers_test.go:126
        	            				/mnt/vss/_work/1/s/e2e/scenario_helpers_test.go:99
        	            				/mnt/vss/_work/1/s/e2e/scenario_test.go:775
        	            				/mnt/vss/_work/1/s/e2e/scenario_test.go:766
        	Error:      	Received unexpected error:
        	            	PUT https://management.azure.com/subscriptions/8ecadfc9-d1a3-4ea4-b844-0d9f87e4d7c8/resourceGroups/MC_abe2e-westus3_abe2e-kubenet-331fc_westus3/providers/Microsoft.Compute/virtualMachineScaleSets/y603-2024-12-18-ubuntu2204gpua100
        	            	--------------------------------------------------------------------------------
        	            	RESPONSE 409: 409 Conflict
        	            	ERROR CODE: OperationNotAllowed
        	            	--------------------------------------------------------------------------------
        	            	{
        	            	  "error": {
        	            	    "code": "OperationNotAllowed",
        	            	    "message": "Operation could not be completed as it results in exceeding approved StandardNCADSA100v4Family Cores quota. Additional details - Deployment Model: Resource Manager, Location: WestUS3, Current Limit: 50, Current Usage: 48, Additional Required: 24, (Minimum) New Limit Required: 72. Setup Alerts when Quota reaches threshold. Learn more at https://aka.ms/quotamonitoringalerting . Submit a request for Quota increase at https://aka.ms/ProdportalCRP/#blade/Microsoft_Azure_Capacity/UsageAndQuota.ReactView/Parameters/%7B%22subscriptionId%22:%228ecadfc9-d1a3-4ea4-b844-0d9f87e4d7c8%22,%22command%22:%22openQuotaApprovalBlade%22,%22quotas%22:[%7B%22location%22:%22WestUS3%22,%22providerId%22:%22Microsoft.Compute%22,%22resourceName%22:%22StandardNCADSA100v4Family%22,%22quotaRequest%22:%7B%22properties%22:%7B%22limit%22:72,%22unit%22:%22Count%22,%22name%22:%7B%22value%22:%22StandardNCADSA100v4Family%22%7D%7D%7D%7D]%7D by specifying parameters listed in the ‘Details’ section for deployment to succeed. Please read more about quota limits at [https://docs.microsoft.com/en-us/azure/azure-supportability/per-vm-quota-requests"](https://docs.microsoft.com/en-us/azure/azure-supportability/per-vm-quota-requests%22)
        	            	  }
        	            	}
        	            	--------------------------------------------------------------------------------
        	Test:       	Test_Ubuntu2204_GPUA100
--- FAIL: Test_Ubuntu2204_GPUA100 (30.44s)

@cameronmeissner
Copy link
Collaborator

@cameronmeissner Could you please have another round of review?

The E2E failed due to quota issue. Should we skip it?

=== NAME  Test_Ubuntu2204_GPUA100
    vmss.go:75: 
        	Error Trace:	/mnt/vss/_work/1/s/e2e/vmss.go:75
        	            				/mnt/vss/_work/1/s/e2e/scenario_helpers_test.go:126
        	            				/mnt/vss/_work/1/s/e2e/scenario_helpers_test.go:99
        	            				/mnt/vss/_work/1/s/e2e/scenario_test.go:775
        	            				/mnt/vss/_work/1/s/e2e/scenario_test.go:766
        	Error:      	Received unexpected error:
        	            	PUT https://management.azure.com/subscriptions/8ecadfc9-d1a3-4ea4-b844-0d9f87e4d7c8/resourceGroups/MC_abe2e-westus3_abe2e-kubenet-331fc_westus3/providers/Microsoft.Compute/virtualMachineScaleSets/y603-2024-12-18-ubuntu2204gpua100
        	            	--------------------------------------------------------------------------------
        	            	RESPONSE 409: 409 Conflict
        	            	ERROR CODE: OperationNotAllowed
        	            	--------------------------------------------------------------------------------
        	            	{
        	            	  "error": {
        	            	    "code": "OperationNotAllowed",
        	            	    "message": "Operation could not be completed as it results in exceeding approved StandardNCADSA100v4Family Cores quota. Additional details - Deployment Model: Resource Manager, Location: WestUS3, Current Limit: 50, Current Usage: 48, Additional Required: 24, (Minimum) New Limit Required: 72. Setup Alerts when Quota reaches threshold. Learn more at https://aka.ms/quotamonitoringalerting . Submit a request for Quota increase at https://aka.ms/ProdportalCRP/#blade/Microsoft_Azure_Capacity/UsageAndQuota.ReactView/Parameters/%7B%22subscriptionId%22:%228ecadfc9-d1a3-4ea4-b844-0d9f87e4d7c8%22,%22command%22:%22openQuotaApprovalBlade%22,%22quotas%22:[%7B%22location%22:%22WestUS3%22,%22providerId%22:%22Microsoft.Compute%22,%22resourceName%22:%22StandardNCADSA100v4Family%22,%22quotaRequest%22:%7B%22properties%22:%7B%22limit%22:72,%22unit%22:%22Count%22,%22name%22:%7B%22value%22:%22StandardNCADSA100v4Family%22%7D%7D%7D%7D]%7D by specifying parameters listed in the ‘Details’ section for deployment to succeed. Please read more about quota limits at [https://docs.microsoft.com/en-us/azure/azure-supportability/per-vm-quota-requests"](https://docs.microsoft.com/en-us/azure/azure-supportability/per-vm-quota-requests%22)
        	            	  }
        	            	}
        	            	--------------------------------------------------------------------------------
        	Test:       	Test_Ubuntu2204_GPUA100
--- FAIL: Test_Ubuntu2204_GPUA100 (30.44s)

we can skip this if the relevant scenarios have passed - please make sure to run once more before merging at least

@bingosummer bingosummer force-pushed the binxi/ni-containerd-config branch from b898ee1 to fe2c731 Compare January 9, 2025 03:29
@bingosummer bingosummer force-pushed the binxi/ni-containerd-config branch from fe2c731 to 0a5a489 Compare January 14, 2025 02:54
@bingosummer bingosummer force-pushed the binxi/ni-containerd-config branch from 0a5a489 to 6a8791f Compare January 21, 2025 05:44
@bingosummer bingosummer changed the base branch from ccoa/2024-2025 to master January 21, 2025 05:44
@bingosummer bingosummer enabled auto-merge (squash) January 21, 2025 05:45
@bingosummer bingosummer force-pushed the binxi/ni-containerd-config branch from 7f311c8 to 4c81577 Compare January 24, 2025 05:58
@bingosummer bingosummer merged commit aa7567f into master Jan 24, 2025
19 checks passed
@bingosummer bingosummer deleted the binxi/ni-containerd-config branch January 24, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants