add cloud-node-manager/credential provider v1.32.2 to vhd image #5907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinForReal
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright,
zachary-bailey,
bravebeaver and
smith1511
as code owners
MartinForReal
force-pushed
the
shafan/cloudprovider
branch
from
ce1c165 to
37a4102
Compare
MartinForReal
changed the title
MartinForReal
force-pushed
the
shafan/cloudprovider
branch
from
37a4102 to
416fcde
Compare
MartinForReal
force-pushed
the
shafan/cloudprovider
branch
from
416fcde to
d4c92a4
Compare
mainred
approved these changes
Feb 25, 2025
mainred
reviewed
Feb 25, 2025
| @@ -470,6 +470,10 @@ | |||
| "renovateTag": "registry=https://mcr.microsoft.com, name=oss/kubernetes/azure-cloud-node-manager", | |||
| "latestVersion": "v1.31.2", | |||
| "previousLatestVersion": "v1.31.1" | |||
| }, | |||
There was a problem hiding this comment.
Since renovate can only bump versions and cannot create new release, we don't have to rely on renovate to introduce this cache.
|
https://msazure.visualstudio.com/CloudNativeCompute/_build/results?buildId=116123177&view=logs&jobId=0f8b8c4a-8219-5725-8fee-15683a5710b0&j=0f8b8c4a-8219-5725-8fee-15683a5710b0&t=754f3dbf-ba92-554b-fcb6-442d131fb984 build failed due to qutoa error. Is there any way to resolve this issue? |
|
I know @timmy-wright fixed the windows quota issue once, but sure if you can help fix it again and help review the PR. |
Devinwong
approved these changes
Feb 25, 2025
MartinForReal
force-pushed
the
shafan/cloudprovider
branch
from
ec77664 to
2ce57fa
Compare
MartinForReal
force-pushed
the
shafan/cloudprovider
branch
from
2ce57fa to
01e1d6d
Compare
MartinForReal
changed the title
|
@Devinwong PTAL. Thanks! |
MartinForReal
force-pushed
the
shafan/cloudprovider
branch
from
01e1d6d to
9296daa
Compare
|
@Devinwong I'm wondering if there is any workaround to fix disk full issue in windows VHD |
Sorry for late reply. I will defer to @timmy-wright for Windows question. 🙂 |
|
But you also need to resolve the conflict first. |
timmy-wright
reviewed
Mar 4, 2025
parts/common/components.json
Outdated
| @@ -1274,7 +1290,7 @@ | |||
| { | |||
| "k8sVersion": "1.32", | |||
| "renovateTag": "OCI_registry=https://mcr.microsoft.com, name=oss/binaries/kubernetes/kubernetes-node", | |||
| "latestVersion": "v1.32.1", | |||
| "latestVersion": "v1.32.2", | |||
There was a problem hiding this comment.
This seems odd that we're updating latestVersion and not updateing previousLatestVersion - usually we'd change previousLatest to the previous latest rather than leave it the same.
There was a problem hiding this comment.
correct. The idea is lastest and latest-1
timmy-wright
reviewed
Mar 4, 2025
| @@ -470,6 +470,10 @@ | |||
| "renovateTag": "registry=https://mcr.microsoft.com, name=oss/kubernetes/azure-cloud-node-manager", | |||
| "latestVersion": "v1.31.2", | |||
| "previousLatestVersion": "v1.31.1" | |||
| }, | |||
There was a problem hiding this comment.
This file should not need updating - it's just test data.
timmy-wright
reviewed
Mar 4, 2025
timmy-wright
requested changes
Mar 4, 2025
There was a problem hiding this comment.
- revert the changes to components-test.json. It's a test file and we shouldn't change it unless we're adding a new feature to the file.
This PR is likely to hit our VHD size issue, so we might need to remove some older versions of azure-cloud-node-manager- one change to the cached version doesn't seem to have updated the previousVersion that we cache on the VHD. This risks a mismatch between what RP wants and what the VHD provides. Which can create IcMs (I had a sev2 yesterday due to this!)
MartinForReal
force-pushed
the
shafan/cloudprovider
branch
from
9296daa to
e98e148
Compare
|
Changes cached containers or packages on windows VHDs diff --git a/vhd_files/2019-containerd.txt b/vhd_files/2019-containerd.txt
index 6bb701f..7ae2d0c 100644
--- a/vhd_files/2019-containerd.txt
+++ b/vhd_files/2019-containerd.txt
@@ -11,0 +12 @@
+ "c:\\akse-cache\\credential-provider\\: https://acs-mirror.azureedge.net/cloud-provider-azure/v1.32.3/binaries/azure-acr-credential-provider-windows-amd64-v1.32.3.tar.gz",
@@ -83,0 +85,2 @@
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3",
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3-windows-hpc",
diff --git a/vhd_files/2022-containerd-gen2.txt b/vhd_files/2022-containerd-gen2.txt
index 78ffba2..525c8d1 100644
--- a/vhd_files/2022-containerd-gen2.txt
+++ b/vhd_files/2022-containerd-gen2.txt
@@ -11,0 +12 @@
+ "c:\\akse-cache\\credential-provider\\: https://acs-mirror.azureedge.net/cloud-provider-azure/v1.32.3/binaries/azure-acr-credential-provider-windows-amd64-v1.32.3.tar.gz",
@@ -122,0 +124,2 @@
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3",
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3-windows-hpc",
diff --git a/vhd_files/2022-containerd.txt b/vhd_files/2022-containerd.txt
index 64af0c8..5ba31f3 100644
--- a/vhd_files/2022-containerd.txt
+++ b/vhd_files/2022-containerd.txt
@@ -11,0 +12 @@
+ "c:\\akse-cache\\credential-provider\\: https://acs-mirror.azureedge.net/cloud-provider-azure/v1.32.3/binaries/azure-acr-credential-provider-windows-amd64-v1.32.3.tar.gz",
@@ -122,0 +124,2 @@
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3",
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3-windows-hpc",
diff --git a/vhd_files/2025-gen2.txt b/vhd_files/2025-gen2.txt
index d81cabf..0137be4 100644
--- a/vhd_files/2025-gen2.txt
+++ b/vhd_files/2025-gen2.txt
@@ -10,0 +11 @@
+ "c:\\akse-cache\\credential-provider\\: https://acs-mirror.azureedge.net/cloud-provider-azure/v1.32.3/binaries/azure-acr-credential-provider-windows-amd64-v1.32.3.tar.gz",
@@ -63,0 +65,2 @@
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3",
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3-windows-hpc",
diff --git a/vhd_files/2025.txt b/vhd_files/2025.txt
index 7f05175..b35596f 100644
--- a/vhd_files/2025.txt
+++ b/vhd_files/2025.txt
@@ -10,0 +11 @@
+ "c:\\akse-cache\\credential-provider\\: https://acs-mirror.azureedge.net/cloud-provider-azure/v1.32.3/binaries/azure-acr-credential-provider-windows-amd64-v1.32.3.tar.gz",
@@ -63,0 +65,2 @@
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3",
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3-windows-hpc",
diff --git a/vhd_files/23H2-gen2.txt b/vhd_files/23H2-gen2.txt
index df56e04..36ba3b4 100644
--- a/vhd_files/23H2-gen2.txt
+++ b/vhd_files/23H2-gen2.txt
@@ -10,0 +11 @@
+ "c:\\akse-cache\\credential-provider\\: https://acs-mirror.azureedge.net/cloud-provider-azure/v1.32.3/binaries/azure-acr-credential-provider-windows-amd64-v1.32.3.tar.gz",
@@ -69,0 +71,2 @@
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3",
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3-windows-hpc",
diff --git a/vhd_files/23H2.txt b/vhd_files/23H2.txt
index 7b8f61f..7c0ab8e 100644
--- a/vhd_files/23H2.txt
+++ b/vhd_files/23H2.txt
@@ -10,0 +11 @@
+ "c:\\akse-cache\\credential-provider\\: https://acs-mirror.azureedge.net/cloud-provider-azure/v1.32.3/binaries/azure-acr-credential-provider-windows-amd64-v1.32.3.tar.gz",
@@ -69,0 +71,2 @@
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3",
+ "mcr.microsoft.com/oss/kubernetes/azure-cloud-node-manager:v1.32.3-windows-hpc", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
add cloud-node-manager:v1.32.1 to vhd image
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: