test: add taints e2e test for scriptless. #5909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devinwong
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright,
zachary-bailey,
bravebeaver and
smith1511
as code owners
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Devinwong
commented
Feb 24, 2025
| @@ -843,18 +843,20 @@ func Test_Ubuntu2204_ChronyRestarts_Taints_And_Tolerations(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func Test_Ubuntu2204_ChronyRestarts_Scriptless(t *testing.T) { | |||
| func Test_Ubuntu2204_ChronyRestarts_Taints_And_Tolerations_Scriptless(t *testing.T) { | |||
There was a problem hiding this comment.
Intentionally add the taints test into this existing test.
r2k1
reviewed
Feb 24, 2025
r2k1
reviewed
Feb 24, 2025
aks-node-controller/proto/aksnodeconfig/v1/kubelet_config.proto
Outdated
Show resolved
Hide resolved
r2k1
reviewed
Feb 24, 2025
aks-node-controller/proto/aksnodeconfig/v1/kubelet_config.proto
Outdated
Show resolved
Hide resolved
…zure/AgentBaker into devinwon/scriptless_taints_e2e
r2k1
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
What this PR does / why we need it:
test: add taints e2e test for scriptless.
Fix a related bug.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: