minor change: Replace the hardcoded VM SKU #5910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zylxjtu
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
timmy-wright,
zachary-bailey,
bravebeaver and
smith1511
as code owners
rzlink
reviewed
Feb 25, 2025
| @@ -619,6 +619,9 @@ func nvidiaDevicePluginDaemonSet() *appsv1.DaemonSet { | |||
| }, | |||
| }, | |||
| Spec: corev1.PodSpec{ | |||
| NodeSelector: map[string]string{ | |||
There was a problem hiding this comment.
Is this change necessary for this PR?
There was a problem hiding this comment.
I think it is better to have. the "nvidia-device-plugin" can not be pulled on windows node, so if you check the pods on the AKS cluster being tested, you will see a failing pod. it does not fail the e2e test though, but I think we better to fix it.
zylxjtu
force-pushed
the
yuanliang/e2etest
branch
from
421a2ff to
35050f8
Compare
zylxjtu
force-pushed
the
yuanliang/e2etest
branch
from
35050f8 to
71f7efa
Compare
There was a problem hiding this comment.
The PR looks good. Given it’s the linux E2E tests failing, we should get someone from the Linux team to comment - I’m not sure if these tests are known to fail in master or not. Your change is super unlikely to have caused any to fail, but better safe than sorry.
|
@cameronmeissner would you please help to take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Replace the hardcoded VM SKU with the one configured in the config file.
Make the "nvidia-device-plugin" deployed in linux node only. It is not able to deploy to windows node, although it will not fail the test
Requirements:
Special notes for your reviewer:
Release note: