chore: move base image urls to pipeline vars #5933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-wright
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
zachary-bailey,
bravebeaver and
smith1511
as code owners
AbelHu
reviewed
Feb 27, 2025
| @@ -59,6 +59,22 @@ parameters: | |||
| displayName: Branch in aks-rp to use for overrides | |||
| type: string | |||
| default: master | |||
| - name: ws2019BaseImageUrl | |||
There was a problem hiding this comment.
We keep these variables as secret and do not want to expose the values in any logs.
There was a problem hiding this comment.
I think it's OK to expose them in the devops logs as they are only accessible internally. Also, anyone who has access to the pipelines can view the variables or parameters that were used to run the pipelines - so I'm not sure we gain much by using variables.
zylxjtu
reviewed
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind chore
What this PR does / why we need it:
Moves the base image URLs to pipeline params rather than pipeline vars. This will make it easier to add new windows versions in the future. Also fixes a bug where the wrong base VHD was being passed to WS-2022-gen2 VHD builds.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: