perf: validate credentials and check apiserver connectivity before starting kubelet #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronmeissner
requested review from
Devinwong,
lilypan26,
r2k1,
timmy-wright,
juan-lee,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
zachary-bailey,
bravebeaver and
smith1511
as code owners
djsly
reviewed
Mar 5, 2025
parts/linux/cloud-init/artifacts/validate-kubelet-credentials.sh
Outdated
Show resolved
Hide resolved
cameronmeissner
changed the title
…eissner/token-validation
|
No changes to cached containers or packages on Windows VHDs |
added 2 commits
March 7, 2025 13:30
|
No changes to cached containers or packages on Windows VHDs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
we recently discovered that in cases where the kubelet tries to begin bootstrapping its client credential before its bootstrap token has been installed into the running control plane, kubelet will attempt to retry bootstrapping with a very aggressive exponential backoff which ends up causing node registration to be unnecessarily delayed
this PR adds a new script which is responsible for validating that kubelet's credential, whether that be a kubeconfig or bootstrap-kubeconfig, is valid and can be used to successfully authenticate with the apiserver via
kubectl auth whoami. this script will be run as a further ExecStartPre specified within the kubelet.service unit file.we already validate that the apiserver is up and reachable before starting kubelet to ensure that we avoid falling into the same trap of kubelet's backoff loop
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: