Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: don't create k8s_downloads_dir if var is not set #5984

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

AlisonB319
Copy link
Collaborator

@AlisonB319 AlisonB319 commented Mar 4, 2025

What type of PR is this? We were seeing a regression in cse latency. In the discovery the error

+ local k8s_downloads_dir=
...
+ mkdir -p
mkdir: missing operand

was found. Devin's PR - 2ea272b solves the root of the problem, eliminating an unncessary call to extractKubeBinaries, while this PR addresses not using the k8s_downloads_dir if it is not set.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

Copy link

There was an error handling pipeline event d2035ddf-f25b-4dec-89a8-acf304c2fab0.

@AlisonB319 AlisonB319 changed the title bug: fix when downloading to k8s_downloads_dir bug: don't create k8s_downloads_dir if var is not set Mar 5, 2025
Copy link
Collaborator

@Devinwong Devinwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlisonB319 AlisonB319 enabled auto-merge (squash) March 5, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants