draft: add file and test for file #5995
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-wright
force-pushed
the
timmy/ensure-right-vhd-used
branch
from
f97a342 to
1eec3c4
Compare
timmy-wright
force-pushed
the
timmy/ensure-right-vhd-used
branch
from
521e929 to
ef9c7ce
Compare
|
No changes to cached containers or packages on Windows VHDs |
timmy-wright
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1,
zachary-bailey,
bravebeaver and
smith1511
as code owners
timmy-wright
commented
Mar 6, 2025
| @@ -903,6 +903,9 @@ try | |||
| Clear-TempFolder | |||
| Log-VHDFreeSize | |||
| Test-AzureExtensions | |||
|
|
|||
| Write-Output "creating test.txt file" | |||
| Write-Output "this is a test file" > "c:\k\test.txt" | |||
There was a problem hiding this comment.
Reminder to Tim: I have to remove this once I've tested the e2e tests are running against the right VHDs.
timmy-wright
commented
Mar 6, 2025
| @@ -25,6 +25,7 @@ func Test_Windows2019Containerd(t *testing.T) { | |||
| ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote") | |||
| ValidateWindowsProcessHasCliArguments(ctx, s, "kubelet.exe", []string{"--rotate-certificates=true", "--client-ca-file=c:\\k\\ca.crt"}) | |||
| ValidateCiliumIsNotRunningWindows(ctx, s) | |||
| ValidateFileHasContent(ctx, s, "/k/test.txt", "this is a test file") | |||
There was a problem hiding this comment.
These are currently here to check the e2e tests are being run with the right VHD version. They will be removed before I merge the PR.
timmy-wright
commented
Mar 6, 2025
e2e/vmss.go
Outdated
| s.T.Logf("vhd rgr id %s", nodeBootstrapping.SigImageConfig.ResourceGroup) | ||
| s.T.Logf("vhd galler %s", nodeBootstrapping.SigImageConfig.Gallery) | ||
| s.T.Logf("vhd versio %s", nodeBootstrapping.SigImageConfig.Version) | ||
| s.T.Logf("vhd defini %s", nodeBootstrapping.SigImageConfig.Definition) |
There was a problem hiding this comment.
Reminder: remove these logs.
timmy-wright
commented
Mar 6, 2025
e2e/vmss.go
Outdated
| @@ -74,6 +80,11 @@ func createVMSS(ctx context.Context, s *Scenario) *armcompute.VirtualMachineScal | |||
|
|
|||
| s.PrepareVMSSModel(ctx, s.T, &model) | |||
|
|
|||
| s.T.Logf("vhd rgr id %s", nodeBootstrapping.SigImageConfig.ResourceGroup) | |||
There was a problem hiding this comment.
reminder: remove these logs
timmy-wright
commented
Mar 6, 2025
| @@ -181,6 +181,7 @@ steps: | |||
|
|
|||
| make -f packer.mk test-building-vhd | |||
| displayName: Run VHD cache test | |||
| enabled: false | |||
There was a problem hiding this comment.
Reminder: re-enable this step.
timmy-wright
force-pushed
the
timmy/ensure-right-vhd-used
branch
from
018d245 to
059d308
Compare
|
No changes to cached containers or packages on Windows VHDs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: