no dns check when http_proxy is configured #6002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsly
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
phealy,
r2k1,
timmy-wright,
zachary-bailey,
bravebeaver and
smith1511
as code owners
|
No changes to cached containers or packages on Windows VHDs |
cameronmeissner
approved these changes
Mar 6, 2025
|
unit test failed, probably because of |
bravebeaver
reviewed
Mar 7, 2025
| registry_domain_name="${MCR_REPOSITORY_BASE:-mcr.microsoft.com}" | ||
| registry_domain_name="${registry_domain_name%/}" | ||
| # Avoid DNS check when http proxy is configured since the DNS resolution will be done through the proxy | ||
| if [[ "${SHOULD_CONFIGURE_HTTP_PROXY}" != "true" ]]; then |
There was a problem hiding this comment.
the two if blocks checking ${BOOTSTRAP_PROFILE_CONTAINER_REGISTRY_SERVER} and ${SHOULD_CONFIGURE_HTTP_PROXY} on surface are not complete to cover all situations. not sure whether this block should move up to join line 63..
should registry_domain_name always have a value?
bravebeaver
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: