fix comments, rename logging constants to match new behavior

Azure · Jan 13, 2025 · cd62a68 · cd62a68
1 parent 9ed77af
commit cd62a68
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationOptions.cs b/src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationOptions.cs
@@ -63,7 +63,7 @@ public class AzureAppConfigurationOptions
         internal TokenCredential Credential { get; private set; }
 
         /// <summary>
-        /// Key Value and Feature Flag selectors specified by user.
+        /// A collection of <see cref="KeyValueSelector"/> specified by user.
         /// </summary>
         internal IEnumerable<KeyValueSelector> Selectors => _selectors;
 

diff --git a/...Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs b/...Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
@@ -360,7 +360,7 @@ await ExecuteWithFailOverPolicyAsync(clients, async (client) =>
 
                                         data = await LoadSelected(client, watchedKvEtags, watchedFfEtags, _options.Selectors, cancellationToken).ConfigureAwait(false);
 
-                                        logInfoBuilder.Append(LogHelper.BuildSelectedKeyValueCollectionsUpdatedMessage());
+                                        logInfoBuilder.Append(LogHelper.BuildSelectedKeyValuesAndFeatureFlagsUpdatedMessage());
                                     }
                                 }
 

diff --git a/src/Microsoft.Extensions.Configuration.AzureAppConfiguration/Constants/LoggingConstants.cs b/src/Microsoft.Extensions.Configuration.AzureAppConfiguration/Constants/LoggingConstants.cs
@@ -29,7 +29,7 @@ internal class LoggingConstants
         public const string RefreshKeyValueSettingUpdated = "Setting updated.";
         public const string RefreshKeyVaultSettingUpdated = "Setting updated from Key Vault.";
         public const string RefreshFeatureFlagsUpdated = "Feature flags updated.";
-        public const string RefreshSelectedKeyValueCollectionsUpdated = "Selected key-value collections updated.";
+        public const string RefreshSelectedKeyValuesAndFeatureFlagsUpdated = "Selected key-value collections and feature flags updated.";
 
         // Other
         public const string RefreshSkippedNoClientAvailable = "Refresh skipped because no endpoint is accessible.";

diff --git a/src/Microsoft.Extensions.Configuration.AzureAppConfiguration/LogHelper.cs b/src/Microsoft.Extensions.Configuration.AzureAppConfiguration/LogHelper.cs
@@ -35,9 +35,9 @@ public static string BuildSelectedKeyValueCollectionsUnchangedMessage(string end
             return $"{LoggingConstants.RefreshSelectedKeyValueCollectionsUnchanged} Endpoint:'{endpoint?.TrimEnd('/')}'";
         }
 
-        public static string BuildSelectedKeyValueCollectionsUpdatedMessage()
+        public static string BuildSelectedKeyValuesAndFeatureFlagsUpdatedMessage()
         {
-            return LoggingConstants.RefreshSelectedKeyValueCollectionsUpdated;
+            return LoggingConstants.RefreshSelectedKeyValuesAndFeatureFlagsUpdated;
         }
 
         public static string BuildKeyVaultSecretReadMessage(string key, string label)
-Original file line number
+Diff line change
@@ Expand Up @@
                                             data = await LoadSelected(client, watchedKvEtags, watchedFfEtags, _options.Selectors, cancellationToken).ConfigureAwait(false);
-                                            logInfoBuilder.Append(LogHelper.BuildSelectedKeyValueCollectionsUpdatedMessage());
+                                            logInfoBuilder.Append(LogHelper.BuildSelectedKeyValuesAndFeatureFlagsUpdatedMessage());
                                         }
                                     }
@@ Expand Down @@