Shorten the default timeout of individual call to backend #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs:1136
- Ensure that the new timeout behavior introduced by checking for TaskCanceledException with an inner TimeoutException is covered by tests.
TaskCanceledException tce = ex.InnerExceptions?.LastOrDefault(e => e is TaskCanceledException) as TaskCanceledException;
zhenlan
approved these changes
Feb 17, 2025
avanigupta
approved these changes
Feb 18, 2025
RichardChen820
force-pushed
the
user/junbchen/shorten_timeout_of_each_call
branch
from
71a346e to
4e7f8b0
Compare
|
@RichardChen820 why don't merge this? @amerjusupovic @jimmyca15 is there a plan to release 8.1.1? Should this be included? |
|
Discussed offline. Won't block the 8.1.1 train. This change will be included in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shorten the default timeout of individual call to backend