set default refresh interval for featureFlag (#9)

Azure · Jan 30, 2024 · 276803f · 276803f
1 parent 237d661
commit 276803f
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 4 deletions.
diff --git a/api/v1/azureappconfigurationprovider_types.go b/api/v1/azureappconfigurationprovider_types.go
@@ -73,8 +73,8 @@ type AzureAppConfigurationKeyValueOptions struct {
 
 // AzureAppConfigurationFeatureFlagOptions defines the options of fetching feature flags from AppConfiguration.
 type AzureAppConfigurationFeatureFlagOptions struct {
-	Selectors []Selector       `json:"selectors,omitempty"`
-	Refresh   *RefreshSettings `json:"refresh,omitempty"`
+	Selectors []Selector                  `json:"selectors,omitempty"`
+	Refresh   *FeatureFlagRefreshSettings `json:"refresh,omitempty"`
 }
 
 // KeyLabelSelector defines the filters when fetching the data from Azure AppConfiguration
@@ -156,6 +156,14 @@ type RefreshSettings struct {
 	Enabled bool `json:"enabled,omitempty"`
 }
 
+type FeatureFlagRefreshSettings struct {
+	// +kubebuilder:validation:Format=duration
+	// +kubebuilder:default="30s"
+	Interval string `json:"interval"`
+	// +kubebuilder:default=false
+	Enabled bool `json:"enabled,omitempty"`
+}
+
 type AzureKeyVaultAuth struct {
 	*AzureAppConfigurationProviderAuth `json:",inline,omitempty"`
 	KeyVaults                          []AzureKeyVaultPerVaultAuth `json:"keyVaults,omitempty"`

diff --git a/api/v1/zz_generated.deepcopy.go b/api/v1/zz_generated.deepcopy.go
diff --git a/internal/controller/utils.go b/internal/controller/utils.go
@@ -18,7 +18,7 @@ import (
 const (
 	MinimalSentinelBasedRefreshInterval time.Duration = time.Second
 	MinimalSecretRefreshInterval        time.Duration = time.Minute
-	MinimalFeatureFlagRefreshInterval   time.Duration = time.Minute
+	MinimalFeatureFlagRefreshInterval   time.Duration = time.Second
 )
 
 func verifyObject(spec acpv1.AzureAppConfigurationProviderSpec) error {