Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 696 fix #697

Merged
merged 3 commits into from
Oct 31, 2024
Merged

PR 696 fix #697

merged 3 commits into from
Oct 31, 2024

Conversation

danycontre
Copy link
Collaborator

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Fixing icons from PR 696

Breaking Changes

  1. None

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

Copy link
Contributor

@swathibhat1 swathibhat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danycontre danycontre merged commit 5822233 into main Oct 31, 2024
6 checks passed
danycontre added a commit that referenced this pull request Oct 31, 2024
* uncommented private link from avm modules

* added private endpoints for avd

* updated readme links

* updated avd private link documentation

* deployment launcher fix (#696)

* PR 696 fix (#697)

* deployment launcher fix

* pr 696 fix

---------

Co-authored-by: Dany Contreras <[email protected]>
@danycontre danycontre deleted the issue-695 branch November 4, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants