Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for EntraID identities #754

Merged
merged 52 commits into from
Mar 6, 2025

Conversation

shawntmeyer
Copy link
Contributor

@shawntmeyer shawntmeyer commented Feb 23, 2025

Overview/Summary

This PR adds support for Entra ID identities for both FSLogix and AppAttach storage and session host configuration.

This PR fixes/adds/changes/removes

Addresses issue 746

  1. fixes - bugs with finding Azure Virtual Desktop and Azure Virtual Desktop ARM Provider service principals by changing the filter query and adding transforms and if all else fails adding Selector Blade Controls if not found.
  2. fixes - network resource group creation if no networking deployed. This was a portal bug.
  3. addition - Entra ID identity option and updates to conditions on deployments to incorporate this new feature. Existing references to EntraID changed to EntraIDKerberos to allow conditions like contains(item, 'EntraID').
  4. addition - Portal UI changes on both baseline and new Session Host brown field scenarios to support dynamic population of accelerated networking, trusted launch, and availability zone support.
  5. modify - Set-SessionHostConfiguration.ps1 script to utilize storage account keys for entra id support. Removed duplicate parameters to slim down code. Calculation of storage account name from share path. calculation of storage fqdn from sharepath.

Breaking Changes

  1. None encountered during testing but anything else that uses the Set-SessionHostConfiguration.ps1 or the bicep calling this might break. I can work through these other brown field issues if found.

Testing Evidence

Tested both EntraID and ADDS identities multiple times in my commercial and government labs. When testing make sure all files are up to date in your repo as I did change the Set-SessionHostConfig.ps1 script as well.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (AVD LZA Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

@danycontre danycontre changed the base branch from main to EntraID-Storage-Features March 5, 2025 20:25
@danycontre danycontre merged commit d3d80cf into Azure:EntraID-Storage-Features Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants