Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve init performance #117

Merged
merged 1 commit into from
Oct 25, 2024
Merged

improve init performance #117

merged 1 commit into from
Oct 25, 2024

Conversation

ms-henglu
Copy link
Member

Previously the extension loads all the type definition during initialization, and this is used to differentiate between the read only types and normal resource types. But this could be really time-consuming, so this PR disables this feature to improve the performance.

Now the initialization only takes 100ms to finish, previously it was 33s.

@ms-henglu ms-henglu requested a review from magodo October 24, 2024 06:12
@mybayern1974
Copy link

Would this change bring the impact that at the client editor side, the content auto-complete feature would show hints for read-only properties? If so, those shown info would be less meaningful to users given those props are not configurable?

@ms-henglu
Copy link
Member Author

Would this change bring the impact that at the client editor side, the content auto-complete feature would show hints for read-only properties? If so, those shown info would be less meaningful to users given those props are not configurable?

@mybayern1974 - No. But when user inputs the value for type in the azapi_resource resource block, the auto-completion will show all resource types including the readonly ones. Comparing with the slow initialization, the impact is acceptable.

@ms-henglu ms-henglu merged commit 3928e98 into main Oct 25, 2024
6 of 8 checks passed
@ms-henglu ms-henglu deleted the branch-241024-improve-perf branch October 25, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants