Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support new bicep types format #93

Merged
merged 2 commits into from
Mar 1, 2024
Merged

support new bicep types format #93

merged 2 commits into from
Mar 1, 2024

Conversation

ms-henglu
Copy link
Member

@ms-henglu ms-henglu commented Feb 29, 2024 •
edited
Loading

This PR supports the new format of bicep types, the main changes are:

  1. The builtInType is deprecated and removed. The StringType/IntegerType/BooleanType/AnyType are added.
  2. There're some new fields added, like "sensitive", "maxLength", "minLength", "maxValue" and "minValue"
  3. The structure of index and each type file is changed.

To help code review, the auto-generated files are in the first commit, please only review the second commit and after. Thanks!

@ms-henglu ms-henglu requested a review from magodo February 29, 2024 07:24
magodo
magodo approved these changes Mar 1, 2024
View reviewed changes
Copy link

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ms-henglu ms-henglu merged commit 8744484 into main Mar 1, 2024
4 checks passed
@ms-henglu ms-henglu deleted the branch-240228-new-bicep-types branch April 22, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magodo magodo magodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-henglu @magodo