[Role] az role assignment list: Add --fill-role-definition-name to allow omitting principalName property
#31152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| role assignment list | cmd role assignment list added parameter fill_role_definition_name |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
jiasli
force-pushed
the
fill_role_definition_name
branch
from
9d6e08e to
66cd34d
Compare
jiasli
commented
Mar 31, 2025
There was a problem hiding this comment.
This recording file previously contains 8 requests with /providers/Microsoft.Authorization/roleDefinitions?api-version=2022-05-01-preview. Now it contains only 4.
jiasli
force-pushed
the
fill_role_definition_name
branch
from
66cd34d to
280f5c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az role definition listDescription
With the ever-increasing number of built-in roles, the list returned by Role Definitions - List API is getting bigger and bigger (#30579), making
az role assignment listcommand slower.In our test subscription,
role_defsatazure-cli/src/azure-cli/azure/cli/command_modules/role/custom.py
Lines 273 to 274 in 919923c
contains 653 items with the size of 588563 bytes, bloating recording files to megabytes big, exceeding the limit of Git diff.
This PR adds
--fill-role-definition-nameto allow omittingroleDefinitionNameproperty, similar to #30693.Testing Guide
Additional information
#30587 uses
roleNamefilter to accelerateaz role definition list, but foraz role definition list, this would require making a REST call for each role definition. Giving the user the choice whether to fillroleDefinitionNameproperty is still mandatory.