Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add accelnet support on CNI #2853

Merged
merged 41 commits into from
Aug 7, 2024
Merged

add accelnet support on CNI #2853

merged 41 commits into from
Aug 7, 2024

Conversation

paulyufan2
Copy link
Contributor

Reason for Change:

This PR is to add accelnet support on CNI;

Issue Fixed:

Requirements:

Notes:

@paulyufan2 paulyufan2 added the cni Related to CNI. label Jul 12, 2024
@paulyufan2 paulyufan2 requested review from a team as code owners July 12, 2024 20:34
QxBytes
QxBytes reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@QxBytes QxBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think there is currently a compilation error in network_windows_test.go which prevents this test from running in windows.

tamilmani1989
tamilmani1989 requested changes Jul 15, 2024
View reviewed changes
tamilmani1989
tamilmani1989 reviewed Jul 16, 2024
View reviewed changes
tamilmani1989
tamilmani1989 reviewed Jul 17, 2024
View reviewed changes
tamilmani1989
tamilmani1989 requested changes Jul 18, 2024
View reviewed changes
@paulyufan2 paulyufan2 force-pushed the paul/accelnetNICSupport branch 9 times, most recently from be78167 to 902f869 Compare July 25, 2024 20:18
@paulyufan2 paulyufan2 force-pushed the paul/accelnetNICSupport branch from 902f869 to 6a40651 Compare July 26, 2024 19:45
tamilmani1989
tamilmani1989 reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few comments

@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 force-pushed the paul/accelnetNICSupport branch from 153e98c to 3854f03 Compare July 31, 2024 13:44
paulyufan2 added 23 commits August 7, 2024 10:21
@paulyufan2
add more uts
872826f
@paulyufan2
fix an linter issue
032c14c
@paulyufan2
fix comments
b24e3ad
@paulyufan2
add comment for iov flag
ee5212d
@paulyufan2
fix comments
9233e67
@paulyufan2
add endpoint deletion
611bad0
@paulyufan2
add HNSV2 check
97ab9a5
@paulyufan2
add UT to make sure endpoint and networ deletion called
9f106f3
@paulyufan2
add a new test to make infraNIC network is not deleted
c7b49ed
@paulyufan2
add errMsg
cfbc3a9
@paulyufan2
fix error msg
a0468be
@paulyufan2
add windows test cases for endpoint state deletion
5edbd02
@paulyufan2
fix linter issue
b49ab11
@paulyufan2
fix a linter issue
71b9df8
@paulyufan2
remove hardcode hcniov flag
fdb13c3
@paulyufan2
comments fix
3024def
@paulyufan2
add uts for transparent network deletion
5672103
@paulyufan2
fix comment when hns id is empty
a613497
@paulyufan2
fix the UT when hns id is empty
47cbfea
@paulyufan2
skip linter issue
9f03288
@paulyufan2
change the delegatedVMNIC to NodeNetworkInterfaceFrontendNIC
90c0146
@paulyufan2
fix an ut
5104bdf
@paulyufan2
fix add accelnet policy setting ut
7ec45ad
@paulyufan2 paulyufan2 force-pushed the paul/accelnetNICSupport branch from 85e66f6 to 7ec45ad Compare August 7, 2024 14:21
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit ae690d2 Aug 7, 2024
11 checks passed
@paulyufan2 paulyufan2 deleted the paul/accelnetNICSupport branch August 7, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmurudi kmurudi kmurudi left review comments

@QxBytes QxBytes QxBytes left review comments

@tamilmani1989 tamilmani1989 tamilmani1989 approved these changes

@rbtr rbtr Awaiting requested review from rbtr rbtr is a code owner automatically assigned from Azure/acn-cni-reviewers

Assignees
No one assigned
Labels
cni Related to CNI. windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulyufan2 @tamilmani1989 @kmurudi @QxBytes