Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor cni telemetry #3149

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat: refactor cni telemetry #3149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
19fc17f
move telemetry to dedicated package and create package variable
QxBytes Nov 7, 2024
7d75abf
send telemetry for ipam config, epinfo, and error on cni add completion
QxBytes Nov 8, 2024
2db2c83
add new telemetry logs for debugging
QxBytes Nov 11, 2024
18fb09e
replace nwcfg subcontext with containerid for correlation
QxBytes Nov 11, 2024
2775cef
add mutex
QxBytes Nov 13, 2024
e0f9baf
address linter issues
QxBytes Nov 14, 2024
58401d3
add unit tests
QxBytes Nov 14, 2024
427f567
set operation id before sending any events for sampling
QxBytes Nov 15, 2024
8221079
remove newly added telemetry events
QxBytes Nov 15, 2024
bfc7e4f
refactor plugin main
QxBytes Nov 18, 2024
f1c9187
add unit tests and simplify
QxBytes Nov 18, 2024
d8fab90
remove duplicate error telemetry
QxBytes Nov 19, 2024
ff279cf
fix comment
QxBytes Nov 19, 2024
782445b
remove writing telemetry events to the log file
QxBytes Nov 19, 2024
d99da53
address feedback
QxBytes Nov 19, 2024
b5c68a9
remove stutter
QxBytes Nov 19, 2024
573ca52
remove unused map (noop)
QxBytes Nov 21, 2024
19b4227
address feedback
QxBytes Dec 5, 2024
4a97303
fix condition
QxBytes Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions cni/network/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,14 @@ import (
"encoding/json"
"io"
"os"
"reflect"

"github.com/Azure/azure-container-networking/cni"
"github.com/Azure/azure-container-networking/telemetry"
"github.com/containernetworking/cni/pkg/skel"
cniTypes "github.com/containernetworking/cni/pkg/types"
"github.com/pkg/errors"
"go.uber.org/zap"
)

// send error report to hostnetagent if CNI encounters any error.
func ReportPluginError(reportManager *telemetry.ReportManager, tb *telemetry.TelemetryBuffer, err error) {
logger.Error("Report plugin error")
reflect.ValueOf(reportManager.Report).Elem().FieldByName("ErrorMessage").SetString(err.Error())

if err := reportManager.SendReport(tb); err != nil {
logger.Error("SendReport failed", zap.Error(err))
}
}

func validateConfig(jsonBytes []byte) error {
var conf struct {
Name string `json:"name"`
Expand Down
Loading
Loading