Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use AppArmorProfile for cilium 1.16 #3371

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Conversation

camrynl
Copy link
Contributor

@camrynl camrynl commented Jan 27, 2025

Reason for Change:
AppArmor annotations are deprecated in kubernetes 1.30+, moving cilium 1.16 chart away from annotations and using security context for AppArmorProfile instead.

Issue Fixed:

Requirements:

Notes:

@camrynl camrynl requested a review from a team as a code owner January 27, 2025 22:46
Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should also be changed in the nightly configs

Copy link
Contributor

@jpayne3506 jpayne3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can we wait for #3379 to merge to ensure this is fixed in nightly?

Copy link

This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Feb 14, 2025
@jpayne3506 jpayne3506 added ci Infra or tooling. and removed stale Stale due to inactivity. labels Feb 20, 2025
@jpayne3506
Copy link
Contributor

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jpayne3506 jpayne3506 added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 4824a8b Feb 21, 2025
14 checks passed
@jpayne3506 jpayne3506 deleted the camrynl/apparmor branch February 21, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants