Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route issues on Swiftv2 Windows #3375

Merged
merged 53 commits into from
Feb 4, 2025
Merged

fix: route issues on Swiftv2 Windows #3375

merged 53 commits into from
Feb 4, 2025

Conversation

paulyufan2
Copy link
Contributor

@paulyufan2 paulyufan2 commented Jan 28, 2025

Reason for Change:

This is the long term solution to fix Swiftv2 Windows Routes issues to make sure windows cns gets all required cidrs from AKS.
Fixes include:
1.Windows CNS gets infravnet/pod/node cidrs from configs
2.Add these routes and send them to the CNI

Issue Fixed:

In Linux Swiftv2, CNS fetches infravnet/pod/node cidrs from the node's envs set by AKS; we should do same thing for Windows;

Requirements:

This PR is based on npm-lite PR with cns middleware refactoring and linked with this PR:
#3205

Notes:

@paulyufan2 paulyufan2 requested a review from rbtr January 29, 2025 22:01
QxBytes
QxBytes previously approved these changes Jan 29, 2025
@paulyufan2 paulyufan2 changed the title Coderefactorcnsswiftv2 fix: route issues on Swiftv2 Windows Jan 30, 2025
rbtr
rbtr previously approved these changes Jan 30, 2025
Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff against #3286 LGTM, thanks for integrating the OS changes here

@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 requested a review from kmurudi January 30, 2025 20:30
@paulyufan2 paulyufan2 dismissed stale reviews from rbtr and QxBytes via 1de9834 January 31, 2025 02:59
Copy link
Contributor

@kmurudi kmurudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending testing/validation on cluster

@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr added this pull request to the merge queue Feb 4, 2025
Merged via the queue into master with commit 962b7f3 Feb 4, 2025
14 checks passed
@rbtr rbtr deleted the coderefactorcnsswiftv2 branch February 4, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cns Related to CNS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants