Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start breaking up CNS main #3465

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rbtr
Copy link
Contributor

@rbtr rbtr commented Mar 1, 2025

no code changes, only rearranging.
starting to break up the huge spaghetti that is main

@Copilot Copilot bot review requested due to automatic review settings March 1, 2025 00:18
@rbtr rbtr requested a review from a team as a code owner March 1, 2025 00:18
@rbtr rbtr requested a review from csfmomo March 1, 2025 00:18
@rbtr rbtr enabled auto-merge March 1, 2025 00:18
@rbtr
Copy link
Contributor Author

rbtr commented Mar 1, 2025

/azp run Azure Container Networking PR

@rbtr rbtr self-assigned this Mar 1, 2025
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr rbtr added the cns Related to CNS. label Mar 1, 2025
@rbtr rbtr requested review from pjohnst5, QxBytes and jpayne3506 March 1, 2025 00:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR is a chore aimed at starting the process of breaking up the large CNS main file into smaller, more manageable components.

  • Introduces a new file for version information in cns/service/version.go
  • Sets up a helper function to print application version details

Reviewed Changes

File Description
cns/service/version.go Adds a helper for printing version details

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

cns/service/version.go:1

  • [nitpick] The file is located in the 'cns/service' directory but declares 'package main'. Consider renaming it (e.g., to 'service') to align with its directory context.
package main
@rbtr rbtr requested a review from nddq March 1, 2025 00:40
Copy link
Contributor

@nddq nddq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik there is no code changes, right? also I was wondering if moving main out of cns/service would be an option down the line 🤔

@rbtr
Copy link
Contributor Author

rbtr commented Mar 3, 2025

afaik there is no code changes, right?

No code changes, only copy/pasting.

also I was wondering if moving main out of cns/service would be an option down the line 🤔

eventually - I'm aiming for cobra. But it's very far down the line.

@rbtr rbtr requested a review from paulyufan2 March 7, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cns Related to CNS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants