-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: start breaking up CNS main #3465
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Evan Baker <[email protected]>
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR is a chore aimed at starting the process of breaking up the large CNS main file into smaller, more manageable components.
- Introduces a new file for version information in cns/service/version.go
- Sets up a helper function to print application version details
Reviewed Changes
File | Description |
---|---|
cns/service/version.go | Adds a helper for printing version details |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
cns/service/version.go:1
- [nitpick] The file is located in the 'cns/service' directory but declares 'package main'. Consider renaming it (e.g., to 'service') to align with its directory context.
package main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik there is no code changes, right? also I was wondering if moving main out of cns/service would be an option down the line 🤔
No code changes, only copy/pasting.
eventually - I'm aiming for cobra. But it's very far down the line. |
no code changes, only rearranging.
starting to break up the huge spaghetti that is
main