chore: update to go1.24 #3467
Open
chore: update to go1.24 #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested review from
ZetaoZhuang,
a team,
camrynl,
paulyufan2,
ashvindeodhar and
thatmattlong
as code owners
There was a problem hiding this comment.
PR Overview
This PR updates the Go version configuration across multiple CI workflows to align with the upgrade to Go 1.24, while also removing an obsolete tools registration file and updating some dependency configurations.
- Update go-version settings from fixed version ranges (e.g. "^1.23") to non-deterministic strings ("latest" or "stable").
- Remove the build/tools/tools.go file, which previously imported various tool dependencies.
- Adjust the invocation of go-junit-report in unit test pipelines.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/cyclonus-netpol-extended-nightly-test.yaml | Updated go-version from "^1.23" to "latest" for Go version configuration. |
| .github/workflows/cyclonus-netpol-test.yaml | Updated go-version from '^1.23' to "latest". |
| .github/workflows/golangci.yaml | Switched go-version to "stable" and updated golangci-lint version to "latest". |
| .github/workflows/codeql.yaml | Updated go-version from "1.23" to "latest". |
| .github/dependabot.yaml | Removed a dependency block for "/build/tools". |
| .github/workflows/crdgen.yaml | Removed matrix configuration and set a fixed runner and go-version to "stable". |
| .pipelines/templates/unit-tests.stages.yaml | Changed go-junit-report invocation to use "go tool go-junit-report". |
| .pipelines/templates/run-unit-tests.yaml | Changed go-junit-report invocation to use "go tool go-junit-report". |
| build/tools/tools.go | Deleted file registering tool dependencies. |
Copilot reviewed 48 out of 48 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
build/tools/tools.go:1
- Removal of the tools.go file may affect dependencies on tool registration; please verify that no parts of the build or tooling process rely on these imports.
package tools
Signed-off-by: Evan Baker <[email protected]>
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notably, this kills
hack/toolsin favor of the new tools directive in the go.mod.Go 1.24 now has FIPS certification of the 1P crypto, but we are currently still required to use MSFT Go...