Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: ci: combine go tests such that any test failure will report a failure for the entire task (#3156) #3488

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

QxBytes
Copy link
Contributor

@QxBytes QxBytes commented Mar 6, 2025

  • add set ex to ci

  • add race and timeout args

  • remove race check

Reason for Change:

Backport #3156

Issue Fixed:

Requirements:

Notes:

… for the entire task (#3156)

* add set ex to ci

* add race and timeout args

* remove race check
@QxBytes QxBytes added ci Infra or tooling. release/1.5 Change affects v1.5 release train labels Mar 6, 2025
@QxBytes QxBytes self-assigned this Mar 6, 2025
@QxBytes
Copy link
Contributor Author

QxBytes commented Mar 6, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@QxBytes QxBytes marked this pull request as ready for review March 6, 2025 23:48
@Copilot Copilot bot review requested due to automatic review settings March 6, 2025 23:48
@QxBytes QxBytes requested a review from a team as a code owner March 6, 2025 23:48
@QxBytes QxBytes requested a review from rohitams March 6, 2025 23:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR backports CI improvements by consolidating multiple Go test commands into a single unified command to ensure that any test failure will mark the entire task as failed.

  • Combines separate "go test" invocations into one command
  • Removes individual directory navigation for testing

Reviewed Changes

File Description
.pipelines/templates/run-unit-tests.yaml Consolidates multiple go test commands into a single script

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.pipelines/templates/run-unit-tests.yaml:42

  • Switching to the 'azure-container-networking' directory may alter the expected relative paths for the npm, cni, and platform subdirectories. Please verify that these directories exist relative to this location.
cd azure-container-networking/
@rbtr rbtr added this pull request to the merge queue Mar 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2025
@QxBytes QxBytes added this pull request to the merge queue Mar 7, 2025
Merged via the queue into release/v1.5 with commit 7f35e74 Mar 7, 2025
22 checks passed
@QxBytes QxBytes deleted the alew/add-set-ex-ut-1-5 branch March 7, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. release/1.5 Change affects v1.5 release train
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants