moved the compute file hash function to utils#46
Merged
Conversation
D1v38om83r
reviewed
Apr 8, 2026
D1v38om83r
reviewed
Apr 8, 2026
D1v38om83r
reviewed
Apr 8, 2026
D1v38om83r
approved these changes
Apr 10, 2026
| value, err := ComputeFileHash(value, hashOpt) | ||
| if hashOpt == hashutils.HashTypeNone { | ||
| // If no hashing is needed, we can directly validate the file content against the allowlist. | ||
| content, err := os.ReadFile(filePath) |
There was a problem hiding this comment.
Streaming via io.Copy instead of os.ReadFile into memory is probably good for large files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small change: moving the Computefilehash() function (and other similar functions) used in extensionpolicysettings to utils before dependencies grow.