-
Notifications
You must be signed in to change notification settings - Fork 466
Exclude test data from functions endpoint response #10943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c11c2c6
to
b60319a
Compare
b60319a
to
d3fd880
Compare
fabiocav
reviewed
Mar 28, 2025
src/WebJobs.Script.WebHost/Extensions/FunctionMetadataExtensions.cs
Outdated
Show resolved
Hide resolved
- Switched from `IOptions<FunctionsHostingConfigOptions>` to `IOptionsMonitor<FunctionsHostingConfigOptions>` - renamed feature flag.
fabiocav
approved these changes
Mar 28, 2025
surgupta-msft
approved these changes
Mar 28, 2025
@microsoft-github-policy-service rerun |
Looks good - thanks Shyju! |
kshyju
added a commit
that referenced
this pull request
Apr 1, 2025
kshyju
added a commit
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies both read and write operations related to test data for functions.
/admin/functions/{name}
PUT operation is called, the "TestData" property will no longer be saved. The response object for this call will not include "TestData" property populated.admin/functions/{name}
GET operation is called, the "TestData" property will no longer be included in the API response.These changes are gated behind a feature flag, which is disabled (set to false) by default. We will begin by enabling this feature on a few stamps and, upon confirming its effectiveness, will roll it out more broadly. In a future release, we plan to remove the feature flag and enable this change by default.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md