Skip to content

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented Mar 24, 2025

This PR modifies both read and write operations related to test data for functions.

  1. When the /admin/functions/{name} PUT operation is called, the "TestData" property will no longer be saved. The response object for this call will not include "TestData" property populated.
  2. When the admin/functions/{name} GET operation is called, the "TestData" property will no longer be included in the API response.

These changes are gated behind a feature flag, which is disabled (set to false) by default. We will begin by enabling this feature on a few stamps and, upon confirming its effectiveness, will roll it out more broadly. In a future release, we plan to remove the feature flag and enable this change by default.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested a review from a team as a code owner March 24, 2025 21:50
@kshyju kshyju force-pushed the shkr/remove-test_data branch from c11c2c6 to b60319a Compare March 24, 2025 21:52
@kshyju kshyju force-pushed the shkr/remove-test_data branch from b60319a to d3fd880 Compare March 24, 2025 22:14
@kshyju kshyju requested a review from mathewc March 24, 2025 22:15
@kshyju kshyju marked this pull request as draft March 25, 2025 20:40
@kshyju kshyju marked this pull request as ready for review March 25, 2025 23:57
- Switched from `IOptions<FunctionsHostingConfigOptions>` to `IOptionsMonitor<FunctionsHostingConfigOptions>`
- renamed feature flag.
@kshyju kshyju requested a review from fabiocav March 28, 2025 17:00
@kshyju kshyju removed the request for review from mathewc March 28, 2025 21:30
@fabiocav
Copy link
Member

@microsoft-github-policy-service rerun

@kshyju kshyju merged commit 8e8c1ce into dev Mar 28, 2025
9 checks passed
@kshyju kshyju deleted the shkr/remove-test_data branch March 28, 2025 23:22
@mathewc
Copy link
Member

mathewc commented Mar 30, 2025

Looks good - thanks Shyju!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants