-
Notifications
You must be signed in to change notification settings - Fork 458
Reduce allocations in DependencyHelper.GetExtensionRequirements #11022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kshyju
wants to merge
5
commits into
dev
Choose a base branch
from
shkr/getextensionreqs-improvements
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
commented
Apr 22, 2025
[Fact] | ||
public void GetExtensionRequirementsReturnsEmbededManifestContent() | ||
{ | ||
var extensionRequirements = DependencyHelper.GetExtensionRequirements(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new test to ensure JSON deserialization works as expected.
7faecfa
to
e5f0958
Compare
@fabiocav @soninaren Could you please review these changes since you both have historical context on this area? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized the following methods to reduce memory allocations and improve deserialization performance:
DependencyHelper.GetExtensionRequirements()
RuntimeAssembliesInfo.GetRuntimeAssemblies()
RuntimeInformationProvider.BuildRuntimesGraph()
These methods previously used JObject.Parse to deserialize embedded JSON resources. This PR replaces them with System.Text.Json and source generation.
Before
After
Delta
DependencyHelper.GetExtensionRequirements
– Total allocations dropped by 4,280 (91.06%)DependencyHelper.GetExtensionRequirements
– Total allocated size dropped by 319.5 KB (91.23%)RuntimeAssembliesInfo.GetRuntimeAssemblies
– Total allocations dropped by 9,215 (86.56%)RuntimeAssembliesInfo.GetRuntimeAssemblies
– Total allocated size dropped by 676.1 KB (87.21%)Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Additional PR information