-
Notifications
You must be signed in to change notification settings - Fork 4k
[HDInsight] Update api version to 2025-01-15-preview #27837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ayEntraUserInfo ; New-AzHDInsightClusterGatewayEntraUserInfo modify cmd: New-AzHDInsightCluster
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
src/HDInsight/HDInsight.Management.Sdk/Generated/HDInsightManagementClient.cs
Show resolved
Hide resolved
src/HDInsight/HDInsight.Management.Sdk/Generated/HDInsightManagementClient.cs
Show resolved
Hide resolved
src/HDInsight/HDInsight.Management.Sdk/Generated/Models/UpdateGatewaySettingsParameters.cs
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAutoscaleTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAzureMonitorTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAzureMonitorTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightAzureMonitorTests.ps1
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightClusterTests.ps1
Outdated
Show resolved
Hide resolved
src/HDInsight/HDInsight.Test/ScenarioTests/HDInsightClusterTests.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the API version to 2025-01-15-preview, adds support for Entra user authentication (via the new –EntraUserIdentity and –EntraUserFullInfo parameters) to both the New-AzHDInsightCluster and Set-AzHDInsightGatewayCredential cmdlets, and introduces support for using WASB storage with Managed Identity (MSI).
- Updated API version and related documentation examples
- Added Entra user parameters and parameter validation to cmdlets
- Adjusted helper methods and test scripts to incorporate the new parameters and MSI support
Reviewed Changes
Copilot reviewed 24 out of 50 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/HDInsight/HDInsight/help/Set-AzHDInsightGatewayCredential.md | Updated help examples/documentation for new Entra parameters |
src/HDInsight/HDInsight/help/New-AzHDInsightCluster.md | Revised parameter lists and added examples for Entra parameters |
src/HDInsight/HDInsight/ManagementCommands/SetAzureHDInsightGatewayCredentialCommand.cs | Changed parameter requirements and added validation logic for Entra users |
src/HDInsight/HDInsight/ManagementCommands/NewAzureHDInsightClusterCommand.cs | Updated parameter handling and storage account creation logic |
src/HDInsight/HDInsight/ClusterCreateHelper.cs | Modified storage account creation signature to include MSI resource ID, added Entra credential validation |
Test files (various) | Updated test scripts to pass new –Version and Entra parameters |
src/HDInsight/HDInsight.Management.Sdk/README.md | Updated input REST spec references to the new API version |
Comments suppressed due to low confidence (2)
src/HDInsight/HDInsight/ManagementCommands/SetAzureHDInsightGatewayCredentialCommand.cs:119
- The mutually exclusive parameter validation is clearly implemented. Please confirm that the error message meets user expectations and is consistently applied across similar cmdlets.
}
src/HDInsight/HDInsight/ClusterCreateHelper.cs:37
- The validation logic for mutually exclusive gateway credential parameters is implemented correctly. Verify that the use of System.Text.Json for serializing Entra users aligns with the project-wide JSON serialization standards.
}
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 9de8e47.
Description
-EntraUserIdentity
and-EntraUserFullInfo
to cmdletNew-AzHDInsightCluster
to support create cluster with entra user as gateway credential to replace use username and password.-EntraUserIdentity
and-EntraUserFullInfo
to cmdletSet-AzHDInsightGatewayCredential
to update Entra user information for an existing Entra user cluster.New-AzHDInsightCluster
cmdlet.Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.