Skip to content

[HDInsight] Update api version to 2025-01-15-preview #27837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Jun 23, 2025

Conversation

2258093686
Copy link
Member

@2258093686 2258093686 commented May 26, 2025

Description

  • Updated api version to 2025-01-15-preview
  • Added two parameters -EntraUserIdentity and -EntraUserFullInfo to cmdlet New-AzHDInsightCluster to support create cluster with entra user as gateway credential to replace use username and password.
  • Added two parameters -EntraUserIdentity and -EntraUserFullInfo to cmdlet Set-AzHDInsightGatewayCredential to update Entra user information for an existing Entra user cluster.
  • Added support for using WASB storage with Managed Identity (MSI) in the New-AzHDInsightCluster cmdlet.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings May 26, 2025 06:28
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@2258093686 2258093686 marked this pull request as draft May 26, 2025 06:28
Copilot

This comment was marked as outdated.

@vidai-msft vidai-msft requested a review from Copilot June 20, 2025 08:06
Copilot

This comment was marked as outdated.

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot June 23, 2025 06:53
Copilot

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot June 23, 2025 06:59
Copilot

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot June 23, 2025 07:01
Copilot

This comment was marked as outdated.

@2258093686 2258093686 requested a review from Copilot June 23, 2025 07:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the API version to 2025-01-15-preview, adds support for Entra user authentication (via the new –EntraUserIdentity and –EntraUserFullInfo parameters) to both the New-AzHDInsightCluster and Set-AzHDInsightGatewayCredential cmdlets, and introduces support for using WASB storage with Managed Identity (MSI).

  • Updated API version and related documentation examples
  • Added Entra user parameters and parameter validation to cmdlets
  • Adjusted helper methods and test scripts to incorporate the new parameters and MSI support

Reviewed Changes

Copilot reviewed 24 out of 50 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/HDInsight/HDInsight/help/Set-AzHDInsightGatewayCredential.md Updated help examples/documentation for new Entra parameters
src/HDInsight/HDInsight/help/New-AzHDInsightCluster.md Revised parameter lists and added examples for Entra parameters
src/HDInsight/HDInsight/ManagementCommands/SetAzureHDInsightGatewayCredentialCommand.cs Changed parameter requirements and added validation logic for Entra users
src/HDInsight/HDInsight/ManagementCommands/NewAzureHDInsightClusterCommand.cs Updated parameter handling and storage account creation logic
src/HDInsight/HDInsight/ClusterCreateHelper.cs Modified storage account creation signature to include MSI resource ID, added Entra credential validation
Test files (various) Updated test scripts to pass new –Version and Entra parameters
src/HDInsight/HDInsight.Management.Sdk/README.md Updated input REST spec references to the new API version
Comments suppressed due to low confidence (2)

src/HDInsight/HDInsight/ManagementCommands/SetAzureHDInsightGatewayCredentialCommand.cs:119

  • The mutually exclusive parameter validation is clearly implemented. Please confirm that the error message meets user expectations and is consistently applied across similar cmdlets.
            }

src/HDInsight/HDInsight/ClusterCreateHelper.cs:37

  • The validation logic for mutually exclusive gateway credential parameters is implemented correctly. Verify that the use of System.Text.Json for serializing Entra users aligns with the project-wide JSON serialization standards.
            }

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft vidai-msft merged commit 9de8e47 into Azure:main Jun 23, 2025
12 checks passed
vidai-msft added a commit that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants