-
Notifications
You must be signed in to change notification settings - Fork 4k
[PS] ActivityLogAlert breaking change of autorest v4 migration #28031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+117
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a breaking change for ActivityLogAlert cmdlets as part of autorest v4 migration, changing return types from fixed arrays to lists for improved API consistency.
- Updates ActivityLogAlert cmdlets to return lists instead of arrays for better type consistency
- Adds proper breaking change annotations with version deprecation information
- Restructures the solution file to reflect updated project references
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/Monitor/Monitor/ChangeLog.md | Documents breaking changes for ActivityLogAlert cmdlets |
src/Monitor/Monitor/Az.Monitor.psd1 | Updates module metadata including Az.Accounts version dependency |
src/Monitor/Monitor.sln | Restructures ActivityLogAlert project references with new GUIDs |
src/Monitor/ActivityLogAlert.Autorest/README.md | Adds breaking change directives for autorest generation |
src/Monitor/ActivityLogAlert.Autorest/custom/*.ps1 | Adds breaking change annotations to custom cmdlet functions |
src/Monitor/ActivityLogAlert.Autorest/Properties/AssemblyInfo.cs | Creates new assembly info file for the module |
...tivityLogAlert.Autorest/custom/New-AzActivityLogAlertAlertRuleAnyOfOrLeafConditionObject.ps1
Show resolved
Hide resolved
...itor/ActivityLogAlert.Autorest/custom/New-AzActivityLogAlertAlertRuleLeafConditionObject.ps1
Show resolved
Hide resolved
YanaXu
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.