Skip to content

[PS] ActivityLogAlert breaking change of autorest v4 migration #28031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 18, 2025

Conversation

JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Jun 26, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JoyerJin JoyerJin marked this pull request as ready for review July 18, 2025 01:55
@Copilot Copilot AI review requested due to automatic review settings July 18, 2025 01:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a breaking change for ActivityLogAlert cmdlets as part of autorest v4 migration, changing return types from fixed arrays to lists for improved API consistency.

  • Updates ActivityLogAlert cmdlets to return lists instead of arrays for better type consistency
  • Adds proper breaking change annotations with version deprecation information
  • Restructures the solution file to reflect updated project references

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/Monitor/Monitor/ChangeLog.md Documents breaking changes for ActivityLogAlert cmdlets
src/Monitor/Monitor/Az.Monitor.psd1 Updates module metadata including Az.Accounts version dependency
src/Monitor/Monitor.sln Restructures ActivityLogAlert project references with new GUIDs
src/Monitor/ActivityLogAlert.Autorest/README.md Adds breaking change directives for autorest generation
src/Monitor/ActivityLogAlert.Autorest/custom/*.ps1 Adds breaking change annotations to custom cmdlet functions
src/Monitor/ActivityLogAlert.Autorest/Properties/AssemblyInfo.cs Creates new assembly info file for the module

@YanaXu YanaXu merged commit f27c4e6 into main Jul 18, 2025
12 checks passed
@YanaXu YanaXu deleted the joyer/activitylogalert-breakingchange branch July 18, 2025 08:47
@JoyerJin JoyerJin restored the joyer/activitylogalert-breakingchange branch July 21, 2025 05:45
@JoyerJin JoyerJin added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants