Azure Firewall Packet Capture Cmdlet Update [public preview feature]

[nikhilpadhye1]

Description

Added support for Operation field which allows the invoke-packetcapture cmdlet to run start/status/stop operations. Additionally fixed the return type by introducing the PSAzurePacketCaptureResponse object which will return a status code and message which explains the result of the ran operation.
Updated the fields for the packet capture parameters to be inline with the changes
Updated tests and generated help files to be up to date with the latest changes

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

[YanaXu]

/azp run azure-powershell - security-tools

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[YanaXu]

Please update the Changelog.

[bewatersmsft]

LGTM

[YanaXu]

/azp run azure-powershell - security-tools

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[nikhilpadhye1]

@YanaXu should i redact the sasurls in the tests?
This was asked for my previous PR: #25888
looks like i removed the references and skipped the test and then reenabled it as per veryearly.
commit: bd5582c
commit: 9d798c6
but wasnt sure if it was still needed.

[nikhilpadhye1]

Need this checked in before 7/15 branch cut so please let me know, will make suggested changes asap

[YanaXu]

Hi @nikhilpadhye1, The PR change looks fine but the CI check failed. I'll see what's wrong in the CI checks.
And yes, please mask sasurls or other secrets/passwords/...

[nikhilpadhye1]

@YanaXu please let me know whats needed to fix the CI check. Will make those changes ASAP. As mentioned previously looking to have this merged by 7/15 for a branch cut

[YanaXu]

/azp run azure-powershell - security-tools

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[YanaXu]

Hi @nikhilpadhye1 , the CI failed in building the module. Please check it locally with dotnet build.

Build FAILED.

D:\a\_work\1\s\src\Network\Network\AzureFirewall\PacketCaptureParameter\NewAzureFirewallPacketCaptureParameterCommand.cs(66,13): error CS0234: The type or namespace name 'AzureFirewallPacketCaptureOperationType' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\_work\1\s\src\Network\Network\Network.csproj]
D:\a\_work\1\s\src\Network\Network\AzureFirewall\PacketCaptureParameter\NewAzureFirewallPacketCaptureParameterCommand.cs(67,13): error CS0234: The type or namespace name 'AzureFirewallPacketCaptureOperationType' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\_work\1\s\src\Network\Network\Network.csproj]
D:\a\_work\1\s\src\Network\Network\AzureFirewall\PacketCaptureParameter\NewAzureFirewallPacketCaptureParameterCommand.cs(68,13): error CS0234: The type or namespace name 'AzureFirewallPacketCaptureOperationType' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\_work\1\s\src\Network\Network\Network.csproj]
    0 Warning(s)
    3 Error(s)