Compute's migration to TypeSpec for API definitions + DiskRP 2025-01-02 #28168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grizzlytheodore
requested review from
wyunchi-ms,
dolauli,
isra-fel,
VeryEarly,
YanaXu,
vidai-msft,
NoriZC,
notyashhh and
Pan-Qi
as code owners
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy customizations for VM operations and various model partial classes as part of migrating API definitions to TypeSpec, and adjusts the base type for disk restore points.
- Deletes manual extension and operation implementations for
VirtualMachinesOperations - Removes numerous custom model partials in favor of generated definitions
- Changes
DiskRestorePointto inherit fromProxyResourceand minor project file encoding update
Reviewed Changes
Copilot reviewed 13 out of 409 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| VirtualMachinesOperationsExtensions.cs | Removed hand-written extension methods for VM operations |
| VirtualMachinesOperations.cs | Deleted custom operation implementations |
| VirtualMachineScaleSetVMExtension*.cs | Removed custom constructors and updated parameter names |
| VirtualMachineScaleSetExtensionUpdate.cs | Deleted custom partial class |
| VirtualMachineCaptureResult.cs | Deleted custom constructor |
| SubResourceWithColocationStatus.cs | Deleted custom partial class |
| NetworkInterfaceReference.cs | Deleted custom partial class |
| IVirtualMachinesOperations.cs | Deleted interface definitions for VM operations |
| DiskRestorePoint.cs | Changed base class from ProxyOnlyResource to ProxyResource |
| DiskEncryptionSetParameters.cs | Deleted custom partial class |
| CloudServiceNetworkProfile.cs | Deleted custom model code |
| Compute.Management.Sdk.csproj | Removed file-level BOM |
Comments suppressed due to low confidence (1)
src/Compute/Compute.Management.Sdk/Customizations/DiskRestorePoint.cs:6
- [nitpick] Changing the base class from
ProxyOnlyResourcetoProxyResourcecan be breaking for callers relying on the previous type. Document this as a breaking change in the release notes and verify downstream compatibility.
public partial class DiskRestorePoint : ProxyResource
src/Compute/Compute.Management.Sdk/Customizations/VirtualMachineScaleSetVMExtension.cs
Outdated
Show resolved
Hide resolved
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
The file starts with a BOM character, which may lead to encoding issues in some build environments. Consider removing the BOM for consistent parsing across tools.
Suggested change
| <Project Sdk="Microsoft.NET.Sdk"> | |
| <Project Sdk="Microsoft.NET.Sdk"> |
Copilot uses AI. Check for mistakes.
…neScaleSetVMExtension.cs Co-authored-by: Copilot <[email protected]>
6 tasks
|
moved back to #27827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated from #27827 as requested by @YanaXu
this PR reflects, two major updates:
after TypeSpec migration, there were many directives that needed to be added and
it kept running into "maximum calls reached" (stack overflow).
I had a meeting with several track 1 SMEs, and they said it is a known autorest 2 issue and will not be addressed. But Compute still has track 1 dependency so the best solution I found, and they suggested the same thing, is to keep the swagger json within the PS repo and do in place file manipulation with file I added: preprocess-rest-api-spec.ps1 To avoid some of the directives
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.