Onboarding PureStorage to powershell #28178
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
Onboard the PureStorageBlock service to Azure PowerShell by adding mapping entries and autogenerated markdown help for all new cmdlets.
- Added PureStorageBlock mapping in
CreateMappings_rules.json - Generated stub markdown help files for all
Az.PureStorageBlockcmdlets undersrc/PureStorageBlock/PureStorageBlock/help/ - No changelog update or real examples/tests included yet
Reviewed Changes
Copilot reviewed 145 out of 145 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/CreateMappings_rules.json | Added PureStorageBlock alias-to-module mapping |
| src/PureStorageBlock/PureStorageBlock/help/*.md | Added autogenerated markdown help stubs for new cmdlets |
| src/PureStorageBlock/PureStorageBlock/ChangeLog.md | Missing ChangeLog update (no entry added) |
Comments suppressed due to low confidence (3)
src/PureStorageBlock/PureStorageBlock/ChangeLog.md:1
- Add release notes for onboarding the PureStorageBlock service under the ## Upcoming Release header in ChangeLog.md.
<!--
src/PureStorageBlock/PureStorageBlock/help/Update-AzPureStorageBlockStoragePool.md:36
- [nitpick] Replace placeholder examples with real usage snippets and descriptive titles to improve end-user guidance in the help file.
### Example 1: {{ Add title here }}
src/PureStorageBlock/PureStorageBlock/help/New-AzPureStorageBlockStoragePool.md:42
- [nitpick] Populate the example sections with actual command invocations and expected output or remove the placeholder content.
### Example 1: {{ Add title here }}
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| } | ||
|
|
||
| Describe 'Get-AzPureStorageBlockAvsStorageContainer' { | ||
| It 'List' -skip { |
There was a problem hiding this comment.
Please add all necessary tests.
|
|
||
| ### Example 1: {{ Add title here }} | ||
| ```powershell | ||
| {{ Add code here }} |
There was a problem hiding this comment.
Please add all necessary examples. Double check all placeholders.
| @@ -987,5 +987,9 @@ | |||
| { | |||
| "alias": "CloudHsm", | |||
| "module": "CloudHsm" | |||
| }, | |||
There was a problem hiding this comment.
Revert the change of this file.
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
This PR contains changes for onboarding PureStorageBlock service to Azure Powershell.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.