Skip to content

Conversation

mihretkidane-OCI
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 08:36
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is an auto-generated SDK update for the Oracle module, which regenerates the PowerShell cmdlets based on updated OpenAPI specifications from the Oracle.Database service. The update includes new resource types (ResourceAnchors, NetworkAnchors, DbSystems) and significant API changes to existing resources.

  • New anchor resource types and their corresponding cmdlets for resource and network anchors
  • Addition of DbSystem resource management cmdlets and documentation
  • API version updates across all resource types from 2025-03-01 to 2025-09-01
  • Parameter changes in existing cmdlets, particularly around scheduled operations handling

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
generate-info.json Updates generation ID for new SDK build
test/*.Tests.ps1 Adds placeholder Pester test files for new cmdlets (11 files)
examples/*.md Adds placeholder example documentation for new cmdlets (8 files)
docs/*.md Adds comprehensive help documentation for new cmdlets and updates existing ones
UX/Oracle.Database/*.json Updates API versions and adds new resource type definitions
README.md Updates commit hash for the OpenAPI specification source
Comments suppressed due to low confidence (1)

src/Oracle/Oracle.Autorest/docs/Update-AzOracleAutonomousDatabase.md:629

  • The parameter documentation shows a breaking change where -DayOfWeekName, -ScheduledStartTime, and -ScheduledStopTime parameters have been removed and replaced with -ScheduledOperationsList. This is a significant API change that should be properly documented in a changelog and may require migration guidance for existing users.
Type: Microsoft.Azure.PowerShell.Cmdlets.Oracle.Models.IScheduledOperationsTypeUpdate[]
Parameter Sets: UpdateExpanded, UpdateViaIdentityExpanded
Aliases:

Required: False
Position: Named
Default value: None
Accept pipeline input: False
Accept wildcard characters: False

Comment on lines 1 to 22
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}

### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```

```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```

{{ Add description here }}

Copy link
Preview

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All example files contain only placeholder content with template markers like '{{ Add title here }}' and '{{ Add code here }}'. Real examples showing actual usage scenarios, parameters, and expected outputs should be provided to help users understand how to use these cmdlets effectively.

Suggested change
### Example 1: {{ Add title here }}
```powershell
{{ Add code here }}
```
```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```
{{ Add description here }}
### Example 2: {{ Add title here }}
```powershell
{{ Add code here }}
```
```output
{{ Add output here (remove the output block if the example doesn't have an output) }}
```
{{ Add description here }}
### Example 1: Update tags for an Oracle Resource Anchor
```powershell
Update-AzOracleResourceAnchor -ResourceGroupName "MyResourceGroup" -ResourceAnchorName "MyAnchor" -Tags @{ "Environment" = "Production"; "Owner" = "DBTeam" }
ResourceGroupName : MyResourceGroup
Name              : MyAnchor
Tags              : { Environment = Production, Owner = DBTeam }
Location          : eastus
Type              : Microsoft.Oracle/resourceAnchors
Id                : /subscriptions/xxxx/resourceGroups/MyResourceGroup/providers/Microsoft.Oracle/resourceAnchors/MyAnchor

Updates the tags of the specified Oracle Resource Anchor to include "Environment" and "Owner".

Example 2: Update the display name of an Oracle Resource Anchor

Update-AzOracleResourceAnchor -ResourceGroupName "MyResourceGroup" -ResourceAnchorName "MyAnchor" -DisplayName "Production Anchor"
ResourceGroupName : MyResourceGroup
Name              : MyAnchor
DisplayName       : Production Anchor
Location          : eastus
Type              : Microsoft.Oracle/resourceAnchors
Id                : /subscriptions/xxxx/resourceGroups/MyResourceGroup/providers/Microsoft.Oracle/resourceAnchors/MyAnchor

Updates the display name of the specified Oracle Resource Anchor to "Production Anchor".

Copilot uses AI. Check for mistakes.

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this Sep 25, 2025
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly added the Contains Breaking Change This PR contains breaking change label Sep 26, 2025
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@isra-fel
Copy link
Member

isra-fel commented Oct 1, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 2, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 2, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Oct 3, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update src/Oracle/Oracle/ChangeLog.md as well

Copy link

github-actions bot commented Oct 3, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@isra-fel
Copy link
Member

isra-fel commented Oct 3, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contains Breaking Change This PR contains breaking change needs-revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants