[RecoveryServices.Backup] [Ignite] Added new cmdlet for reregistration feature #28628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new cmdlet Redo-AzRecoveryServicesBackupProtection that enables reregistration of backup items between different Recovery Services vaults. The feature allows users to move backup protection for Azure VMs, SQL workloads, and Azure File Shares from one vault to another while preserving data and applying new policies.
Key changes include:
- Added the new
Redo-AzRecoveryServicesBackupProtectioncmdlet with comprehensive parameter support - Implemented helper classes and methods to handle container unregistration, workload discovery, and protection reconfiguration
- Added test coverage for Azure VM reregistration scenarios
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
Redo-AzRecoveryServicesBackupProtection.md |
Documentation for the new cmdlet with syntax, parameters, and usage examples |
Az.RecoveryServices.md |
Updated module documentation to include the new cmdlet |
ChangeLog.md |
Added changelog entry for the reregistration feature |
Az.RecoveryServices.psd1 |
Exported the new cmdlet in module manifest |
RSBackupVaultCmdletBase.cs |
Enhanced job handling methods to support returning job objects |
CmdletHelper.cs |
New helper class with container management and protectable item discovery logic |
BackupUtils.cs |
Added utility methods for job status checking and resource name extraction |
RedoAzureRmRecoveryServicesBackupProtection.cs |
Main cmdlet implementation handling the three-step reregistration process |
ItemTests.ps1 |
PowerShell test script for Azure VM reregistration scenarios |
ItemTests.cs |
C# test class integration for the new test |
| Provider classes | Updated to handle optional parameters in reregistration scenarios |
src/RecoveryServices/RecoveryServices/help/Redo-AzRecoveryServicesBackupProtection.md
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup/Helpers/CmdletHelper.cs
Outdated
Show resolved
Hide resolved
...Services/RecoveryServices.Backup/Cmdlets/Item/RedoAzureRmRecoveryServicesBackupProtection.cs
Outdated
Show resolved
Hide resolved
|
|
||
| // Step 3: Configure backup in target vault | ||
| WriteVerbose("Configuring backup in target vault now"); | ||
| // chck : switch context to the target vault's subscription |
There was a problem hiding this comment.
Comment contains typo: 'chck' should be 'check'. This appears to be a development note that should be completed or removed.
Suggested change
| // chck : switch context to the target vault's subscription | |
| // Check: switch context to the target vault's subscription |
Copilot uses AI. Check for mistakes.
src/RecoveryServices/RecoveryServices.Backup/Helpers/CmdletHelper.cs
Outdated
Show resolved
Hide resolved
...Services/RecoveryServices.Backup/Cmdlets/Item/RedoAzureRmRecoveryServicesBackupProtection.cs
Outdated
Show resolved
Hide resolved
src/RecoveryServices/RecoveryServices.Backup/Helpers/CmdletHelper.cs
Outdated
Show resolved
Hide resolved
hiaga
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
hiaga
force-pushed
the
hiaga/Reregistration
branch
from
139090e to
c96d190
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@isra-fel all checks have passed |
isra-fel
requested review from
wyunchi-ms,
dolauli,
isra-fel,
VeryEarly,
YanaXu,
vidai-msft,
NoriZC,
notyashhh and
Pan-Qi
as code owners
isra-fel
requested changes
Oct 2, 2025
src/RecoveryServices/RecoveryServices/help/Redo-AzRecoveryServicesBackupProtection.md
Outdated
Show resolved
Hide resolved
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
from one vault to another.
This reverts commit 4b28e88.
hiaga
force-pushed
the
hiaga/Reregistration
branch
from
c96d190 to
1b78f2d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
isra-fel
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new cmdlet for reregistration feature
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.