Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release app microsoft.app 2025 01 01 #32578

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Release app microsoft.app 2025 01 01 #32578

wants to merge 15 commits into from

Conversation

najian
Copy link
Member

@najian najian commented Feb 12, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Nan Jiang and others added 13 commits December 4, 2024 13:29
Copy files from stable/2024-03-01
c7d8d36 
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Update version to stable/2025-01-01
3cedd2a 
Updated the API version from stable/2024-03-01 to stable/2025-01-01.
Added tag for 2025-01-01 in readme file
000fb34
@njuCZ
Support keda scaler auth using MSI (#31893)
08b61d7 
* Support keda scaler auth using MSI

* fix lint

* fix lint

* update
@Juliehzl
Add KEDA cooldownPeriod/pollingInterval property for Container App & …
6e7af6c 
…Jobs (#31891)

* add keda propety

* fix prettier

* fix comment
@LaylaLiu-gmail @LaylaLiu
Enable BYO NFS Storage in 2025-01-01 (#31850)
31768b1 
* Enable BYO NFS Storage in 2025-01-01

* Fix code style

* Fix

---------

Co-authored-by: Layla Liu <[email protected]>
@zhenqxuMSFT
Add RunningStatus for ContainerApp (#31984)
f3d51ba
@sonwan2020 @najian
Enable Java Runtime in Microsoft.App 2025-01-01 (#31957)
e239c23 
* Enable Java Runtime in 2025-01-01
---------

Co-authored-by: najian <[email protected]>
@njuCZ
Support env msi and cert from key vault (#31875)
243782d 
* Support env msi and cert from key vault

* add spell check ci
@sonwan2020 @tadelesh
Support Java Components in Microsoft.App version 2025-01-01 (#31958)
0ee668d 
* add java components support in version 2025-01-01

* enable lenient model deduplication in go

---------

Co-authored-by: Chenjie Shi <[email protected]>
@najian
Update proxy resource type to v5 (#31997)
be9f51a 
* update proxy resource type to v5

---------

Co-authored-by: Nan Jiang <[email protected]>
@sonwan2020
remove deduplication config for go sdk (#32111)
f24f5be
@yitaopan
Azure Container Apps SessionPool Api Version 2025-01-01 (#31985)
59b558a 
* SessionPool Api Version 2025-01-01

* Fix example

* DynamicPoolConfiguration.LifecycleConfiguration

* Fix

* Test

* Test

* Test

* test

* Test

* Test

* Test

* Test

* Test

* Test

* Restore

* Test

* Test

* Test

* Restore

* Use TrackedResource for SessionPool patch

* Remove tracked resource and only support tags for patch

* Fix lintdiff

* Update lifecycle type

* Add supress

* fix
@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hi, @najian. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Mar 3, 2025
@najian najian removed the no-recent-activity There has been no recent activity on this issue. label Mar 4, 2025
@najian
Copy link
Member Author

najian commented Mar 4, 2025

Try fix conflict by #32974

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 6, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Breaking Change(Cross-Version) has failed. To unblock this PR, follow the process at aka.ms/brch.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 6, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appcontainers/armappcontainers Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-appcontainers https://apiview.dev/Assemblies/Review/7da9ac1e2db64477ada2ba8bbb71169b?revisionId=1f16c0f266e44d268b5f36f51cff1bae
JavaScript @azure/arm-appcontainers https://apiview.dev/Assemblies/Review/ba41cd9978b542efb0688a072b2319a1?revisionId=340ace55b00d42c8af2cb7de382a4098
Python azure-mgmt-appcontainers https://apiview.dev/Assemblies/Review/1693ff33eb9c4a86a7684539954c49cf?revisionId=3768d14bf6f14e1f81bbe3a2dda032fe

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Mar 6, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.App

@azure-sdk azure-sdk mentioned this pull request Mar 6, 2025
Draft
@najian najian removed the BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. label Mar 7, 2025
@najian
Copy link
Member Author

najian commented Mar 7, 2025

Breaking change review Intake https://msazure.visualstudio.com/One/_workitems/edit/31699358

@najian najian mentioned this pull request Mar 7, 2025
Merged
8 tasks
@najian
Fix LintDiff failed in Release app microsoft.app 2025 01 01 (#33078)
58c987f 
* Fix LintDiff failed
---------

Co-authored-by: Nan Jiang <[email protected]>
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard Awaiting requested review from weshaggard

@mikeharder mikeharder Awaiting requested review from mikeharder

@benbp benbp Awaiting requested review from benbp

@jijohn14 jijohn14 Awaiting requested review from jijohn14 jijohn14 is a code owner

@Juliehzl Juliehzl Awaiting requested review from Juliehzl Juliehzl is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version NotReadyForARMReview PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@najian @azure-sdk @AzureRestAPISpecReview @njuCZ @Juliehzl @LaylaLiu-gmail @zhenqxuMSFT @sonwan2020 @yitaopan @mikeharder