TypeSpec fix for Router Events #32591

grangasamy-msft · 2025-02-12T22:28:49Z

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

Link to API Spec engagement record issue:

Is this review for (select one):

a private preview
a public preview
GA release

Change Scope

^{This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.}

Design Document:
Previous API Spec Doc:
Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting

Guidelines & Specifications

Helpful Links

Schedule a data plane REST API spec review

Getting help

First, please carefully read through this PR description, from top to bottom.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

- Align with formal GH naming

* resolve issue with matrix collation when multiple matrix configs are being resolved --------- Co-authored-by: Scott Beddall <[email protected]>

* add aliases and fix casing * update alias casing * refactor shared code * create alias for shared request params * clean up implementation * merge more request params * format * update alias --------- Co-authored-by: catalinaperalta <[email protected]>

* Fix casing * Revert "Fix casing" This reverts commit d0674aa. * Fix * Update sdk-suppressions.yaml --------- Co-authored-by: kazrael2119 <[email protected]>

* Added number lookup GA * Update comment * update docs comment * fix policy issue

- Includes "npm update"

* first draft of interactive types * interactuve type example * interactive type model fixing * build fix * model update * example fix * review comments * adding stickers and reactions * fixing model * revoming stable version for new types * fixing prettier * fixing build pipeline * fixing build * build fixes * build fixies * readme fix * emoji character fix * model fix * model updates * updating nodel name * build fixes * model and example fixes * build issues * updating documentation * fixing model failures * adding more specific action type to bindings. * build fixes * build fixes * build fixes * types update for message content * merge * Moving action property to leaf node. * updating readme for preview version tag. * merge * merge * updating action property for actionbinding * reverting update * Binding inherited property change. * fixing python schema issue * SDK review comments * java client update * Java review comments * cshard update * review comments * build issues * adding new version * updating new version * build failues * spel checker error fix * build fix * merge issues * final commit * tyspec fix * reverting cspell.json * fix build --------- Co-authored-by: Qiaoqiao Zhang <[email protected]>

- Fixes #32173

- Still has bugs in fork PRs

* Add previous stable API files as baseline * Add 2025-02-15 API Version files * Fix missing example and wrong API version usage * add missing example files * fix API version * simple change in example to trigger github gates which seems to be stuck in queued * fix breaking changes * fix swagger file format * fix swagger file format * Add suppression * fix readme file * fix lintdiff by adding suppression * try to address one model violation failure * fix more model validation * fix more model validation * fix more model validation

…next steps to merge" (#32554)

* added files * update readme

* Add missing response schema * response model * response model2 * format keyvault uri

* Update registries.json * Update registryId property description and casing * Update registryId description in registries.json

* update Get-ObjectKey to coalesce boolean-like values to their true boolean value * update Get-ObjectKey to call Get-ObjectKey on each item of an array or pscustom object - versus utilizing their values directly --------- Co-authored-by: Scott Beddall <[email protected]>

- Required for private repo

Co-authored-by: Patrick Hallisey <[email protected]>

Co-authored-by: Chidozie Ononiwu <[email protected]>

…tration (#32571) * comment Error rename * Comment all C# customizations * KeyVaultSettingValue * Uncomment access decorators * Make KeyVault internal * Omit unreachable types * Move omit-unreachable-types to autorest options * use-model-reader-writer: true * use model reader writer false * Rename Setting,Type to SettingType * Cleanup csharp customizations * format client.tsp * Remove omit-unreachable-types

* Update the docs and examples for public preview api * update docs * update examples * update examples * update examples * add spelling exception * add spelling exceptions --------- Co-authored-by: Mike Harder <[email protected]>

openapi-pipeline-app · 2025-02-12T22:28:53Z

PR validation pipeline started successfully. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

openapi-pipeline-app · 2025-02-12T22:28:54Z

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

mikeharder and others added 30 commits February 7, 2025 17:02

[EngSys] Rename "targetCommitish" to "headCommitish" (#32526)

0def190

- Align with formal GH naming

Sync eng/common directory with azure-sdk-tools for PR 9799 (#32523)

58ca4b7

* resolve issue with matrix collation when multiple matrix configs are being resolved --------- Co-authored-by: Scott Beddall <[email protected]>

Update readme.python.md (#32529)

d152007

Fix casing (#32483)

3e87982

* Fix casing * Revert "Fix casing" This reverts commit d0674aa. * Fix * Update sdk-suppressions.yaml --------- Co-authored-by: kazrael2119 <[email protected]>

update tspconfig (#32536)

53b2029

Add number lookup GA (#31978)

a3d9c16

* Added number lookup GA * Update comment * update docs comment * fix policy issue

Update package openapi-to-typespec to 0.10.9 (#32534)

f4185f5

Bump dev dependency "vitest" (#32540)

b562f50

- Includes "npm update"

[EngSys] Add check ARMAutoSignoffPreview (#32457)

8abab3c

- Fixes #32173

[EngSys] [context.js] Support check_suite:completed (#32544)

97b6de4

[ARMAutoSignOff] Disable check_suite:completed trigger (#32546)

134b331

- Still has bugs in fork PRs

[ARMAutoSignOff] Exclude examples (#32549)

ab2a9e7

[EngSys] Add dependency "@typespec/xml" (#32551)

ed8fd7d

Liftr WeightAndBiases RP (#32486)

98edcbe

Liftr ArizeAi RP (#32485)

982bec0

[ARMAutoSignOff] Trigger on issue_comment:edited when body contains "…

0da14ec

…next steps to merge" (#32554)

[ArmAutoSignoff] Add permissions required in private repo (#32555)

177b67d

Create stable version from 2024-09-23-preview (#32532)

218c824

* added files * update readme

[NetAppFiles] Bugfix Add missing response schema (#32430)

dc6126a

* Add missing response schema * response model * response model2 * format keyvault uri

Update sydnicatedRegistries field in registries.json (#32413)

273c8f2

* Update registries.json * Update registryId property description and casing * Update registryId description in registries.json

[EngSys] [update-labels] Add actions:read permission (#32567)

9fc80e9

- Required for private repo

Parameterize test-pipeline version separator (#32565)

3b99f60

Co-authored-by: Patrick Hallisey <[email protected]>

Support Linux environment (#32568)

1aafda2

Co-authored-by: Chidozie Ononiwu <[email protected]>

Update readme.python.md (#32553)

e6892bb

grangasamy-msft requested a review from a team as a code owner February 12, 2025 22:28

grangasamy-msft requested review from JeffreyRichter and mikekistler and removed request for a team February 12, 2025 22:28

grangasamy-msft closed this Feb 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TypeSpec fix for Router Events #32591

TypeSpec fix for Router Events #32591

grangasamy-msft commented Feb 12, 2025

openapi-pipeline-app bot commented Feb 12, 2025

openapi-pipeline-app bot commented Feb 12, 2025

TypeSpec fix for Router Events #32591

TypeSpec fix for Router Events #32591

Conversation

grangasamy-msft commented Feb 12, 2025

Data Plane API Specification Update Pull Request

PR review workflow diagram

API Info: The Basics

Change Scope

Viewing API changes

Suppressing failures

❔Got questions? Need additional info?? We are here to help!

Tooling

Guidelines & Specifications

Helpful Links

Getting help

openapi-pipeline-app bot commented Feb 12, 2025

openapi-pipeline-app bot commented Feb 12, 2025