Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIR] Add contract changes to ARM repo for startupProbe property #33032

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+44 −1
Open

[MIR] Add contract changes to ARM repo for startupProbe property #33032

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
592a7bc
added optional property
sshiri-msft Mar 5, 2025
4f31483
Merge branch 'main' into sshiri/add_startupprobe_to_arm_api
sshiri-msft Mar 6, 2025
5d85ff3
Merge branch 'main' into sshiri/add_startupprobe_to_arm_api
sshiri-msft Mar 6, 2025
5aad647
Merge branch 'main' into sshiri/add_startupprobe_to_arm_api
sshiri-msft Mar 6, 2025
d56d8c8
Merge branch 'main' into sshiri/add_startupprobe_to_arm_api
sshiri-msft Mar 7, 2025
1a108e5
updated description
sshiri-msft Mar 7, 2025
edf6484
Merge branch 'sshiri/add_startupprobe_to_arm_api' of https://github.c…
sshiri-msft Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .../2025-01-01-preview/examples/OnlineDeployment/ManagedOnlineDeployment/createOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@
"timeout": "PT2S",
"period": "PT10S",
"initialDelay": "PT1S"
},
"startupProbe": {
"failureThreshold": 30,
"successThreshold": 1,
"timeout": "PT2S",
"period": "PT10S",
"initialDelay": "PT1S"
}
},
"tags": {},
Expand Down Expand Up @@ -113,6 +120,13 @@
"timeout": "PT2S",
"period": "PT10S",
"initialDelay": "PT1S"
},
"startupProbe": {
"failureThreshold": 30,
"successThreshold": 1,
"timeout": "PT2S",
"period": "PT10S",
"initialDelay": "PT1S"
}
},
"systemData": {
Expand Down Expand Up @@ -192,6 +206,13 @@
"timeout": "PT2S",
"period": "PT10S",
"initialDelay": "PT1S"
},
"startupProbe": {
"failureThreshold": 30,
"successThreshold": 1,
"timeout": "PT2S",
"period": "PT10S",
"initialDelay": "PT1S"
}
},
"systemData": {
Expand Down
7 changes: 7 additions & 0 deletions .../preview/2025-01-01-preview/examples/OnlineDeployment/ManagedOnlineDeployment/update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@
"timeout": "PT2S",
"period": "PT10S",
"initialDelay": "PT1S"
},
"startupProbe": {
"failureThreshold": 30,
"successThreshold": 1,
"timeout": "PT2S",
"period": "PT10S",
"initialDelay": "PT1S"
}
},
"systemData": {
Expand Down
10 changes: 10 additions & 0 deletions ...es/resource-manager/Microsoft.MachineLearningServices/preview/2025-01-01-preview/mfe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2025-01-01-preview/mfe.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Brownfield services will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.
"swagger": "2.0",
"info": {
"title": "Azure Machine Learning Services",
Expand Down Expand Up @@ -20763,6 +20763,11 @@
"description": "The route to check the readiness of the inference server container.",
"$ref": "#/definitions/Route"
},
"startupRoute": {
"description": "The route to check the startup of the application in the container.",
"$ref": "#/definitions/Route",
"x-nullable": true
},
"scoringRoute": {
"description": "The port to send the scoring requests to, within the inference server container.",
"$ref": "#/definitions/Route"
Expand Down Expand Up @@ -23677,6 +23682,11 @@
"$ref": "#/definitions/ProbeSettings",
"x-nullable": true
},
"startupProbe": {
"description": "This verifies whether the application within a container is started. Startup probes run before any other probe, and, unless it finishes successfully, disables other probes.",
"$ref": "#/definitions/ProbeSettings",
"x-nullable": true
},
"requestSettings": {
"description": "Request settings for the deployment.",
"$ref": "#/definitions/OnlineRequestSettings",
Expand Down
5 changes: 5 additions & 0 deletions ...ingservices/resource-manager/Microsoft.MachineLearningServices/stable/2024-10-01/mfe.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check notice on line 1 in specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/stable/2024-10-01/mfe.json

View workflow job for this annotation

GitHub Actions / TypeSpec Requirement 

Brownfield services will soon be required to convert from OpenAPI to TypeSpec. See https://aka.ms/azsdk/typespec.
"swagger": "2.0",
"info": {
"title": "Azure Machine Learning Services",
Expand Down Expand Up @@ -17868,6 +17868,11 @@
"description": "The route to check the readiness of the inference server container.",
"$ref": "#/definitions/Route"
},
"startupRoute": {
"description": "The route to check the startup of the application in the container.",
"$ref": "#/definitions/Route",
"x-nullable": true
},
"scoringRoute": {
"description": "The port to send the scoring requests to, within the inference server container.",
"$ref": "#/definitions/Route"
Expand Down