-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Search Management Plane 2025-05-01 #33037
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
@microsoft-github-policy-service agree company="Microsoft" |
}, | ||
"paths": { | ||
"/providers/Microsoft.Search/operations": { | ||
"get": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the following set of files - search.json, its not clear what the new changes being introduced are..
When introducing a new API version, create the folder for the new API version and place files from the previous latest API version as is in the first commit. All new changes to the json files that you would like to ship with this new API version you are introducing should only be added in the subsequent commits.
This allows the reviewer to use the diffing capabilities between the commits of a PR in tools like codeflow to get a clear understanding of the actual changes being introduced. With the way the PR is raised now, the reviewer cannot discover what the new changes are. Please either abandon the PR and raise another one with the recommendation or create a new set of commits on this PR following the recommendation. If you have already followed this pattern in this PR, p[lease indicate which commit is the exact copy of the previous version.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.