Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Ingress Configuration to Managed Environment API #33057

Open
wants to merge 3 commits into
base: release-app-Microsoft.App-preview/2025-02-02-Preview
Choose a base branch
from
Open

Adding Ingress Configuration to Managed Environment API #33057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db8bb43
Adding Ingress Configuration to Managed Env
ysoo Mar 6, 2025
68bf64b
Adding to lists
ysoo Mar 6, 2025
600cd4d
Wrong name
ysoo Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 37 additions & 2 deletions ...on/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/ManagedEnvironments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/ManagedEnvironments.json

View check run for this annotation

Azure Pipelines / Swagger PrettierCheck

specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/ManagedEnvironments.json#L1 

specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/ManagedEnvironments.json(1,1): error : Code style issues found, please run prettier.
 > npm install
 > npx prettier --write specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/ManagedEnvironments.json
"swagger": "2.0",
"info": {
"version": "2025-02-02-preview",
Expand Down Expand Up @@ -1733,6 +1733,42 @@
}
}
},
"ingressConfiguration": {
"description": "Settings for the ingress component, including workload profile, scaling, and connection handling.",
"type": "object",
"properties": {
"workloadProfileName": {
"description": "Name of the workload profile used by the ingress component.",
"type": "string"
},
"scale": {
"description": "Scaling configuration for the ingress component.",
"type": "object",
"properties": {
"minReplicas": {
"description": "Minimum number of ingress replicas.",
"type": "integer"
},
"maxReplicas": {
"description": "Maximum number of ingress replicas.",
"type": "integer"
}
}
},
"terminationGracePeriodSeconds": {
"description": "Time (in seconds) to allow active connections to complete on termination.",
"type": "integer"
Copy link

@Tratcher Tratcher Mar 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to represent that this is nullable/optional?

Should the description include defaults? "The default is 600 seconds (8 minutes) if not set."
How about range limits? "The value must be between 0 and 3600 (1 hour)"

},
"headerCountLimit": {
"description": "Maximum number of headers per request allowed by the ingress.",
"type": "integer"
},
"requestIdleTimeout": {
"description": "Duration (in minutes) before idle requests are timed out.",
"type": "integer"
}
}
},
"privateEndpointConnections": {
"description": "Private endpoint connections to the resource.",
"type": "array",
Expand Down Expand Up @@ -1937,5 +1973,4 @@
]
}
]
}

}
33 changes: 31 additions & 2 deletions ...Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_CreateOrUpdate.json

View check run for this annotation

Azure Pipelines / Swagger PrettierCheck

specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_CreateOrUpdate.json#L1 

specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_CreateOrUpdate.json(1,1): error : Code style issues found, please run prettier.
 > npm install
 > npx prettier --write specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_CreateOrUpdate.json
"parameters": {
"subscriptionId": "34adfa4f-cedf-4dc0-ba29-b6d1a69ab345",
"resourceGroupName": "examplerg",
Expand Down Expand Up @@ -110,6 +110,16 @@
"encryption": {
"enabled": true
}
},
"ingressConfiguration": {
"workloadProfileName": "My-CO-01",
"scale": {
"minReplicas": 2,
"maxReplicas": 4
},
"terminationGracePeriodSeconds": 3600,
"headerCountLimit": 30,
"requestIdleTimeout": 5
}
}
}
Expand Down Expand Up @@ -221,6 +231,16 @@
"mtls": {
"enabled": true
}
},
"ingressConfiguration": {
"workloadProfileName": "My-CO-01",
"scale": {
"minReplicas": 2,
"maxReplicas": 4
},
"terminationGracePeriodSeconds": 3600,
"headerCountLimit": 30,
"requestIdleTimeout": 5
}
}
}
Expand Down Expand Up @@ -330,10 +350,19 @@
"mtls": {
"enabled": true
}
},
"ingressConfiguration": {
"workloadProfileName": "My-CO-01",
"scale": {
"minReplicas": 2,
"maxReplicas": 4
},
"terminationGracePeriodSeconds": 3600,
"headerCountLimit": 30,
"requestIdleTimeout": 5
}
}
}
}
}
}

}
13 changes: 11 additions & 2 deletions ...ce-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{

Check failure on line 1 in specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_Get.json

View check run for this annotation

Azure Pipelines / Swagger PrettierCheck

specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_Get.json#L1 

specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_Get.json(1,1): error : Code style issues found, please run prettier.
 > npm install
 > npx prettier --write specification/app/resource-manager/Microsoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_Get.json
"parameters": {
"subscriptionId": "8efdecc5-919e-44eb-b179-915dca89ebf9",
"resourceGroupName": "examplerg",
Expand Down Expand Up @@ -76,10 +76,19 @@
"encryption": {
"enabled": true
}
},
"ingressConfiguration": {
"workloadProfileName": "My-CO-01",
"scale": {
"minReplicas": 2,
"maxReplicas": 4
},
"terminationGracePeriodSeconds": 3600,
"headerCountLimit": 30,
"requestIdleTimeout": 5
}
}
}
}
}
}

}
14 changes: 12 additions & 2 deletions ...soft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_ListByResourceGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,16 @@
"workloadProfileType": "Consumption"
}
],
"ingressConfiguration": {
"workloadProfileName": "My-GP-01",
"scale": {
"maxReplicas": 2,
"minReplicas": 2
},
"terminationGracePeriodSeconds": 600,
"headerCountLimit": 50,
"requestIdleTimeout": null
},
"infrastructureResourceGroup": "capp-svc-jlaw-demo1-northcentralus"
}
},
Expand Down Expand Up @@ -94,12 +104,12 @@
"vnetConfiguration": {
"infrastructureSubnetId": "/subscriptions/34adfa4f-cedf-4dc0-ba29-b6d1a69ab345/resourceGroups/RGName/providers/Microsoft.Network/virtualNetworks/VNetName/subnets/subnetName1"
},
"ingressConfiguration": null,
"infrastructureResourceGroup": "capp-svc-demo1-northcentralus"
}
}
]
}
}
}
}

}
6 changes: 4 additions & 2 deletions ...osoft.App/preview/2025-02-02-preview/examples/ManagedEnvironments_ListBySubscription.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
"workloadProfileType": "Consumption"
}
],
"ingressConfiguration": null,
"infrastructureResourceGroup": "capp-svc-jlaw-demo1-northcentralus"
}
},
Expand Down Expand Up @@ -98,6 +99,7 @@
"expirationDate": "2022-11-06T04:00:00Z",
"thumbprint": "CERTIFICATE_THUMBPRINT"
},
"ingressConfiguration": null,
"eventStreamEndpoint": "testEndpoint",
"infrastructureResourceGroup": "capp-svc-demo1-northcentralus"
}
Expand Down Expand Up @@ -158,12 +160,12 @@
"expirationDate": "2022-11-06T04:00:00Z",
"thumbprint": "CERTIFICATE_THUMBPRINT"
},
"ingressConfiguration": null,
"eventStreamEndpoint": "testEndpoint"
}
}
]
}
}
}
}

}
Loading