Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kamboj prjwl/release network microsoft.network 2024 07 01 #33072

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Kamboj prjwl/release network microsoft.network 2024 07 01 #33072

wants to merge 25 commits into from

Conversation

kamboj-prjwl
Copy link
Member

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

kamboj-prjwl and others added 23 commits December 4, 2024 12:50
@kamboj-prjwl
Copy files from stable/2024-05-01
b131346 
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
@kamboj-prjwl
Update version to stable/2024-07-01
3cab51b 
Updated the API version from stable/2024-05-01 to stable/2024-07-01.
@kamboj-prjwl
Added tag for 2024-07-01 in readme file
51f68f5
@kamboj-prjwl
Prettier Check Fix
25db8a9
@Shubhika-1795
NVA: swagger changes for reimage api (#31895)
83721a7 
* NVA: swagger changes for reimage api

* prettier code

* LintDiff failure addressed
@nanditaashok-ms
API spec for operation to retrieve NVA boot diagnostics (#31819)
7723b07 
* API spec for operation to retrieve NVA boot diagnostics

* made some model validation fixes

* addressed ARM review comments

* trying to address some model validation and symantic failures

* fix lintdiff errors

* fix prettiercheck after merge conflict resolve
@bveerannamsft
Adding new fields for Microsoft peering prefix validation (#31769)
51342b5 
Co-authored-by: Bharath Veeranna <[email protected]>
@EugenioPena
Health api 2024 07 01 (#31787)
bd08745 
* Fixed health API pattern and parameter types.
@nanditaashok-ms
Update boot diagnostics api spec (#32281)
35c7a3a 
* API spec for operation to retrieve NVA boot diagnostics

* made some model validation fixes

* addressed ARM review comments

* trying to address some model validation and symantic failures

* fix lintdiff errors

* fix prettiercheck after merge conflict resolve

* update spec for nva boot diagnostics api for 2024-07-01
@jliusan
add suppression
992f3d5
@sssharma24 @jliusan
adding connectivity capabilities for AVNM (#32461)
848e587 
* adding connectivity capabilities for AVNM

* trailing space

* added descriptions

* add suppression

---------

Co-authored-by: judy.liu <[email protected]>
@EugenioPena
UDP tracking (#32373)
aadd42a 
* UDP tracking

Draft changes for UDP Enable Connection Tracking.
@sssharma24
adding etag support for vnet verifier and ipam (#32410)
1d34cf7
@AJ-2017 @kazrael2119 @jliusan
Removed deprecated APIs from Network Watcher spec (#32358)
351383d 
* Removed deprecated APIs from Network Watcher spec

* reverted stop call

* remove unintended change

* Update sdk-suppressions.yaml

* add suppression

* Resolve prettier error

---------

Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: judy.liu <[email protected]>
@yaarark @yaararm
Add xff support (#32484)
3ecf309 
Co-authored-by: Yaara Rumney <[email protected]>
@Aastha20
[AzureCoreIDC] NSP GA Version (#32556)
15eae99 
* Changes for NSP GA Version

* Adding suppression for failing checks

* resolving comments

* resolving comments

---------

Co-authored-by: Aastha Singh <[email protected]>
@sssharma24
updating examples (#32575)
54ceda1 
* updating examples

* update examples and remove etag from intent
@NiviShenker
Nivishenker/default disabled (#32667)
331d9a0 
ApplicationGateway WAF default disabled
@disinghal18 @kamboj-prjwl
High Bandwidth VPN Gateway property (#32804)
4959f1c 
* VNG schema update

* Swagger changes for high bandwidth vpn gateway

* Refactoring

---------

Co-authored-by: Prajjwal Kamboj <[email protected]>
@Aastha20
resolving typo (#32906)
3dae90c 
* resolving typo

* resolving typo

---------

Co-authored-by: Aastha Singh <[email protected]>
@sssharma24
change array to object for connectivity capabilities (#32860)
686bd5e 
* change item to add prop

* swagger prettier

* changing from array to object

* update example
@Aastha20
Correcting operationId for NSP API (#33050)
5537ec1 
* resolving typo

* resolving typo

* correcting operationID

---------

Co-authored-by: Aastha Singh <[email protected]>
@rutulsya
Adding changes for Virtual Network Gateway Resiliency Information and… (
94b0234 
#32978)

* Adding changes for Virtual Network Gateway Resiliency Information and Route Sets

* Running prettier to remove errors
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 7, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named SpellCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 7, 2025 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/network/armnetwork Create ApiView timeout. Package is too large and we cannot create ApiView for it.
JavaScript @azure/arm-network https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=8395feb2857348d5899aadb93f8a3218
.Net Azure.ResourceManager.Network https://apiview.dev/Assemblies/Review/806ead8231374028b5c49cb90e200641?revisionId=7e972b8028934fdd9e138345790ff251

@github-actions github-actions bot added BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. labels Mar 7, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Network

This was referenced Mar 7, 2025
Draft
Draft
Draft
Draft
Draft
@azure-sdk azure-sdk mentioned this pull request Mar 7, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ARMReview BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Network new-api-version NotReadyForARMReview resource-manager SuppressionReviewRequired
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.