Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VMSS property type in API response #33076

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yanzhudd
Copy link

@yanzhudd yanzhudd commented Mar 7, 2025

There's an Azure CLI issue caused by the inconsistence between the Swagger definition and API response.
The actual response could be object type or string, so the definition should be "any" type instead of "object".

Copy link

openapi-pipeline-app bot commented Mar 7, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Mar 7, 2025

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute Create ApiView timeout. Package is too large and we cannot create ApiView for it.
Java azure-resourcemanager-compute-generated https://apiview.dev/Assemblies/Review/eb099b2efb0f4373a854e09003a6b31d?revisionId=c73b5648cf69444c8430654deeea41ba
.Net Azure.ResourceManager.Compute There is no API change compared with the previous version
JavaScript @azure/arm-compute There is no API change compared with the previous version

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Mar 7, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Compute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Compute NotReadyForARMReview resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants