Skip to content

Conversation

@LarryOsterman
Copy link
Member

SDK configuration pull request

Purpose of this PR

Add Rust bindings to a significant number of tspconfig.yaml files. Note that these bindings do NOT imply that Rust clients will be generated for these packages, neither does it imply that the namespaces for these packages is correct.

Before the decision is made to generate a Rust SDK, please confirm with the architecture board that the package name is correct as is the working directory for the generated package.

  • Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Getting help

  • First, carefully read through this PR description, from top to bottom. Fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@LarryOsterman LarryOsterman added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Nov 20, 2025
@github-actions
Copy link

github-actions bot commented Nov 20, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/advisor/armadvisor
Go sdk/resourcemanager/appconfiguration/armappconfiguration
Go sdk/resourcemanager/azurestackhci/armazurestackhci
Go sdk/resourcemanager/botservice/armbotservice
Go sdk/resourcemanager/cdn/armcdn
Go sdk/resourcemanager/edgeactions/armedgeactions
Go sdk/resourcemanager/consumption/armconsumption
Go sdk/resourcemanager/containerregistry/armcontainerregistry
Go sdk/resourcemanager/containerregistry/armcontainerregistrytasks
Go sdk/resourcemanager/databox/armdatabox
Go sdk/resourcemanager/databoxedge/armdataboxedge
Go sdk/resourcemanager/dataprotection/armdataprotection
Go sdk/resourcemanager/devtestlabs/armdevtestlabs
Go sdk/resourcemanager/dns/armdns
Go sdk/resourcemanager/edgeorder/armedgeorder
Go sdk/resourcemanager/elasticsan/armelasticsan
Go sdk/resourcemanager/eventhub/armeventhub
Go sdk/resourcemanager/fabric/armfabric
Go sdk/resourcemanager/fileshares/armfileshares
Go sdk/resourcemanager/guestconfiguration/armguestconfiguration
Go sdk/resourcemanager/loadtesting/armloadtesting
Go sdk/resourcemanager/maintenance/armmaintenance
Go sdk/resourcemanager/monitor/armmonitor
Go sdk/resourcemanager/mysql/armmysqlflexibleservers
Go sdk/resourcemanager/netapp/armnetapp
Go sdk/resourcemanager/notificationhubs/armnotificationhubs
Go sdk/resourcemanager/postgresqlhsc/armpostgresqlhsc
Go sdk/resourcemanager/powerbidedicated/armpowerbidedicated
Go sdk/resourcemanager/privatedns/armprivatedns
Go sdk/resourcemanager/recoveryservices/armrecoveryservices
Go sdk/resourcemanager/recoveryservices/armrecoveryservicesbackup
Go sdk/resourcemanager/redis/armredis
Go sdk/resourcemanager/relay/armrelay
Go sdk/resourcemanager/servicebus/armservicebus
Go sdk/resourcemanager/servicefabricmanagedclusters/armservicefabricmanagedclusters
Go sdk/resourcemanager/signalr/armsignalr
Go sdk/resourcemanager/sqlvirtualmachine/armsqlvirtualmachine
Go sdk/resourcemanager/storagesync/armstoragesync
Go sdk/resourcemanager/support/armsupport
Go sdk/resourcemanager/trafficmanager/armtrafficmanager
Go sdk/resourcemanager/avs/armavs
Go sdk/resourcemanager/webpubsub/armwebpubsub
Go sdk/widget-analytics/azmanager
Go sdk/resourcemanager/widget/armwidget
Go sdk/resourcemanager/dependencymap/armdependencymap
Go sdk/resourcemanager/azurestackhci/armazurestackhcivm
Go sdk/batch/azbatch
Go sdk/resourcemanager/billingbenefits/armbillingbenefits
Go sdk/resourcemanager/confidentialledger/armconfidentialledger
Go sdk/resourcemanager/confluent/armconfluent
Go sdk/resourcemanager/connectedcache/armconnectedcache
Go sdk/resourcemanager/containerservicenodecustomization/armcontainerservicenodecustomization
Go sdk/resourcemanager/contoso/armcontoso
Go sdk/contosowidgetmanager/azmanager
Go sdk/resourcemanager/dashboard/armdashboard
Go sdk/resourcemanager/databasefleetmanager/armdatabasefleetmanager
Go sdk/resourcemanager/datadog/armdatadog
Go sdk/resourcemanager/devcenter/armdevcenter
Go sdk/resourcemanager/deviceregistry/armdeviceregistry
Go sdk/resourcemanager/devopsinfrastructure/armdevopsinfrastructure
Go sdk/resourcemanager/dynatrace/armdynatrace
Go sdk/resourcemanager/workloadorchestration/armworkloadorchestration
Go sdk/resourcemanager/placeholder/armplaceholder
Go sdk/resourcemanager/commonedgesitemanageroperations/armcommonedgesitemanageroperations
Go sdk/resourcemanager/edgemarketplace/armedgemarketplace
Go sdk/resourcemanager/elastic/armelastic
Go sdk/messaging/eventgrid/aznamespaces
Go sdk/resourcemanager/secretsstoreextension/armsecretsstoreextension
Go sdk/resourcemanager/healthbot/armhealthbot
Go sdk/resourcemanager/hybridkubernetes/armhybridkubernetes
Go sdk/resourcemanager/iotoperations/armiotoperations
Go sdk/resourcemanager/neonpostgres/armneonpostgres
Go sdk/resourcemanager/managednetworkfabric/armmanagednetworkfabric
Go sdk/resourcemanager/reviews/armreviews
Go sdk/search/azsearch
Go sdk/resourcemanager/virtualenclaves/armvirtualenclaves
Go sdk/monitor/ingestion/azlogs
Go sdk/monitor/query/azlogs
Go sdk/monitor/query/azmetrics
Go sdk/resourcemanager/newrelic/armnewrelicobservability
Go sdk/resourcemanager/nginx/armnginx
Go sdk/analytics/azonlineexperimentation
Go sdk/resourcemanager/onlineexperimentation/armonlineexperimentation
Go sdk/resourcemanager/paloaltonetworksngfw/armpanngfw
Go sdk/resourcemanager/programmableconnectivity/armprogrammableconnectivity
Go sdk/resourcemanager/relationships/armrelationships
Go sdk/resourcemanager/resources/armdeploymentstacks
Go sdk/resourcemanager/standbypool/armstandbypool
Go sdk/resourcemanager/terraform/armterraform
Go sdk/resourcemanager/containerservicefleet/armcontainerservicefleet
Go sdk/resourcemanager/resourceconnector/armresourceconnector

@github-actions github-actions bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 21, 2025
@mikeharder
Copy link
Member

@LarryOsterman: You may want to add validation for the rust config here, alongside the validation for the other languages:

https://github.com/Azure/azure-rest-api-specs/blob/main/eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts

@LarryOsterman
Copy link
Member Author

@LarryOsterman: You may want to add validation for the rust config here, alongside the validation for the other languages:

https://github.com/Azure/azure-rest-api-specs/blob/main/eng/tools/typespec-validation/src/rules/sdk-tspconfig-validation.ts

I was thinking about that, but I believe that @heaths has that on his plate. More importantly, I know for certain that the Rust emitter cannot handle many of these crates (it failed 3 out of 5 tries earlier this week). So adding validation right now is likely to be premature.

@heaths
Copy link
Member

heaths commented Nov 21, 2025

Yeah, in the new year. I'm first going to go through and try to generate a Rust crate for every tspconfig.yaml and see where we have gaps. That said, more often than not I see all other languages' SDK steps failing to build so not sure if adding Rust to the mix now makes that any worse. Still, probably better to wait.

@LarryOsterman
Copy link
Member Author

Yeah, in the new year. I'm first going to go through and try to generate a Rust crate for every tspconfig.yaml and see where we have gaps. That said, more often than not I see all other languages' SDK steps failing to build so not sure if adding Rust to the mix now makes that any worse. Still, probably better to wait.

Btw, looking at the validation, some of these can be done now (for instance, validating the output location is valid, validating that management plane SDKs have resource_manager_ in the crate name, etc. I'm still trying to see if this also adds attempting to compile the crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants